Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wxWidgets intial recipe #21353

Merged
merged 28 commits into from
Aug 19, 2024
Merged

Conversation

gmeeker
Copy link
Contributor

@gmeeker gmeeker commented Nov 24, 2023

Specify library name and version: wxwidgets/3.2.3

Implements #5190 #19991 #20092
Requested by #621

This is a new recipe to CCI. It's an updated version from bincrafters but ported to Conan v2 with additional fixes.

https://github.com/bincrafters/community/tree/main/recipes/wxwidgets

Also unmerged GTK3 work from here (using GTK from Conan recipe):

bincrafters/community#1434

GTK support is currently a draft but macOS and Windows seem usable. Any feedback appreciated. For example, do we need anything older than 3.2.3 here?


@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot conan-center-bot added the Missing dependencies Build failed due missing dependencies in Conan Center label Nov 25, 2023
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot conan-center-bot removed the Missing dependencies Build failed due missing dependencies in Conan Center label Nov 25, 2023
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@czoido czoido self-assigned this Aug 3, 2024
Co-authored-by: Martin Valgur <martin.valgur@gmail.com>
@conan-center-bot

This comment has been minimized.

@gmeeker
Copy link
Contributor Author

gmeeker commented Aug 6, 2024

  1. Using GTK from Conan is still not working because that recipe doesn't support Conan v2 yet.
  2. I'm not sure what would happen if you mix a Conan built GTK with system WebKitGTK (and writing a recipe for that looks even more daunting).
  3. wxWidgets is still GTK3 only but I don't think that affects any of this.
  4. I'm not able to use Conan cairo with system GTK. I'm getting missing glib symbols (maybe mixing system + built glibs).

So I'm not sure if this will be solved anytime soon.

@conan-center-bot

This comment has been minimized.

@czoido
Copy link
Contributor

czoido commented Aug 19, 2024

Hi @gmeeker,
Thanks a lot for the contribution, I'm pushing some changes to simplify the options (if it's needed in the future we can always put them back), relying on defaults for the moment and also removing the gtk option until we have a gtk recipe compatible with Conan 2 (I'm working on some changes for the PR open, so I hope it will be soon)

@conan-center-bot conan-center-bot added Failed Missing dependencies Build failed due missing dependencies in Conan Center labels Aug 19, 2024
@conan-center-bot

This comment has been minimized.

@conan-center-bot conan-center-bot removed Failed Missing dependencies Build failed due missing dependencies in Conan Center labels Aug 19, 2024
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 7 (a0e7e28a61ff0c46d266f96f3c56148352679a84):

  • wxwidgets/3.2.5:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 7 (a0e7e28a61ff0c46d266f96f3c56148352679a84):

  • wxwidgets/3.2.5:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit e18fb92 into conan-io:master Aug 19, 2024
12 checks passed
@SpaceIm
Copy link
Contributor

SpaceIm commented Sep 22, 2024

Why is there ninja in build requirements? Putting ninja in build requirement of a recipe doesn't mean that it will be used as CMake generator. It would also require to force tc.generator = "Ninja" in generate(), but it's missing.
Builds pass, and Ninja is not used at all as we can see in build logs, so I think it can be removed.

Comment on lines +100 to +101
if self.options.get_safe("secretstore"):
packages.append("libsecret-1-dev")
Copy link
Contributor

@SpaceIm SpaceIm Sep 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is libsecret in conancenter.

I'm surprised by this recipe. I thought it was forbidden to have system requirements explicitly requested in conancenter recipes (except for a "system" recipe).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question. How did this get past hook checks and human reviews?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants