-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qwt: Update to work with Qt 5 or 6 #21391
base: master
Are you sure you want to change the base?
qwt: Update to work with Qt 5 or 6 #21391
Conversation
This comment has been minimized.
This comment has been minimized.
8370fcf
to
0fcf732
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
313ffd5
to
619ee29
Compare
This comment has been minimized.
This comment has been minimized.
Could you include this minor change in your PR as well, please? #21196 |
@valgur I can do that if you want, not sure of the best way to do that? |
Thanks! You can simply copy the changed line and mention the other PR in the commit message for context info. |
This comment has been minimized.
This comment has been minimized.
6f8990a
to
644c082
Compare
This comment has been minimized.
This comment has been minimized.
644c082
to
242dc58
Compare
This comment has been minimized.
This comment has been minimized.
242dc58
to
ca8f32f
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
0548826
to
6fb0218
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Waiting on #21676 to fix Windows Qt6 build |
59f32f0
to
4972d5d
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't use a version range, otherwise LGTM.
Thanks!
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
071f130
to
828835b
Compare
This comment has been minimized.
This comment has been minimized.
I'm just following up on this PR |
828835b
to
ffd7240
Compare
Conan v1 pipeline ✔️All green in build 8 (
Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping Failure in build 8 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
ffd7240
to
5eab37d
Compare
Co-authored-by: Jordan Williams <jordan@jwillikers.com> qwt: use a more specific license identifier
5eab37d
to
892d043
Compare
Specify library name and version: qwt/6.2.0
This PR allows qwt to build with Qt5 or Qt6, resolving issue #16326 and #10744