Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qwt: Update to work with Qt 5 or 6 #21391

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

ashley-b
Copy link
Contributor

Specify library name and version: qwt/6.2.0

This PR allows qwt to build with Qt5 or Qt6, resolving issue #16326 and #10744


@conan-center-bot

This comment has been minimized.

@ashley-b ashley-b force-pushed the fix/update_qwt_to_work_with_qt6 branch from 8370fcf to 0fcf732 Compare November 27, 2023 06:18
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@ashley-b ashley-b force-pushed the fix/update_qwt_to_work_with_qt6 branch from 313ffd5 to 619ee29 Compare November 27, 2023 11:44
@conan-center-bot

This comment has been minimized.

@valgur
Copy link
Contributor

valgur commented Nov 27, 2023

Could you include this minor change in your PR as well, please? #21196

@ashley-b
Copy link
Contributor Author

@valgur I can do that if you want, not sure of the best way to do that?

@valgur
Copy link
Contributor

valgur commented Nov 28, 2023

@valgur I can do that if you want, not sure of the best way to do that?

Thanks! You can simply copy the changed line and mention the other PR in the commit message for context info.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@ashley-b ashley-b force-pushed the fix/update_qwt_to_work_with_qt6 branch from 242dc58 to ca8f32f Compare December 3, 2023 05:15
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@ashley-b ashley-b force-pushed the fix/update_qwt_to_work_with_qt6 branch from 0548826 to 6fb0218 Compare December 5, 2023 00:30
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@ashley-b
Copy link
Contributor Author

ashley-b commented Dec 9, 2023

Waiting on #21676 to fix Windows Qt6 build

@ashley-b ashley-b force-pushed the fix/update_qwt_to_work_with_qt6 branch from 59f32f0 to 4972d5d Compare March 24, 2024 16:15
@conan-center-bot

This comment has been minimized.

Copy link
Contributor

@valgur valgur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't use a version range, otherwise LGTM.

Thanks!

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@jcar87 jcar87 self-assigned this Jun 11, 2024
@ashley-b
Copy link
Contributor Author

I'm just following up on this PR

@ashley-b ashley-b force-pushed the fix/update_qwt_to_work_with_qt6 branch from 828835b to ffd7240 Compare October 1, 2024 06:18
@conan-center-bot conan-center-bot added Failed Missing dependencies Build failed due missing dependencies in Conan Center labels Oct 1, 2024
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 8 (ffd72406bbad6dad61e812ca5b85181118fc7ba9):

  • qwt/6.2.0:
    All packages built successfully! (All logs)

Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

Failure in build 8 (ffd72406bbad6dad61e812ca5b85181118fc7ba9):

  • qwt/6.2.0:
    CI failed to create some packages (All logs)

    Logs for packageID e4bfac69e660d643318cba944da69409ddc53d6a:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.cppstd=17
    compiler.libcxx=libstdc++11
    compiler.version=11
    os=Linux
    [options]
    */*:shared=False
    
    [...]
        qwt/6.2.0#2b29cb883b6562ecbcbbfbc7419a77e7:e4bfac69e660d643318cba944da69409ddc53d6a - Build
        sqlite3/3.46.1#3af96a6e95bb5a1c183ca6ead71592cc:46fbaf6d13261d8e27269f7addcf948d9d8e7b59#de552f0de4c47034d8520612f8ff40b6 - Download (conan-center)
        util-linux-libuuid/2.39.2#339f80aea7e5cf507b5b9839a128909f:b647c43bfefae3f830561ca202b6cfd935b56205#7d1c19f47892fc2f2b18ea1d0b030095 - Download (conan-center)
        wayland/1.22.0#284b56bdbe57868770f46100784e3b4d:f8be1ca6cbd6997090bb03596e62d3eb351cfe64#3e640b890d32aad1e3ed2edd49e82e37 - Download (conan-center)
        xkbcommon/1.5.0#91e39b3619ef0d4f17ec09f303935208:577479e1204019b1f986be22caa9bd397eb31b88#44125354bab4e6d25d5932d1c375e9ec - Download (conan-center)
        xkeyboard-config/system#57dd5c08e72ab06bc2ee0e756c0a2c41:da39a3ee5e6b4b0d3255bfef95601890afd80709#0ba8627bd47edc3a501e8f0eb9a79e5e - Download (conan-center)
        xorg/system#98f82cb669e4ebc6b4d9d8a4f3f1faf4:da39a3ee5e6b4b0d3255bfef95601890afd80709#0ba8627bd47edc3a501e8f0eb9a79e5e - Download (conan-center)
        zlib/1.3.1#f52e03ae3d251dec704634230cd806a2:b647c43bfefae3f830561ca202b6cfd935b56205#6b307bbcbae23635c4006543ffdbf3ef - Download (conan-center)
        zstd/1.5.5#1f239731dc45147c7fc2f54bfbde73df:c1b14c3945d5adf1e5ae440c43c12f88117f2edc#5766258f0ea4ee0d0a66a93cffb8b93a - Download (conan-center)
    Build requirements
        autoconf/2.71#f9307992909d7fb3df459340f1932809:da39a3ee5e6b4b0d3255bfef95601890afd80709#5b77f70c17ad1741f5845d4e468a347e - Download (conan-center)
        automake/1.16.5#058bda3e21c36c9aa8425daf3c1faf50:9a4eb3c8701508aa9458b1a73d0633783ecc2270#9719e51a6a62041af6a63e00eef35434 - Download (conan-center)
        m4/1.4.19#b38ced39a01e31fef5435bc634461fd2:3593751651824fb813502c69c971267624ced41a#cd8019a4f9b70880d548f7cc26569604 - Download (conan-center)
        opengl/system#4df6fecde4084386beded3ed0e56e4ea:da39a3ee5e6b4b0d3255bfef95601890afd80709#0ba8627bd47edc3a501e8f0eb9a79e5e - Download (conan-center)
        qt/5.15.14#8e99c640555798c4c2b5dedfcff7c394:4c99b7425bb13c54fa9ab3327a5baa03fcde9240#8c0104ac09fbaf74e58e6e516a79ac8c - Download (conan-center)
        xkeyboard-config/system#57dd5c08e72ab06bc2ee0e756c0a2c41:da39a3ee5e6b4b0d3255bfef95601890afd80709#0ba8627bd47edc3a501e8f0eb9a79e5e - Download (conan-center)
        xorg/system#98f82cb669e4ebc6b4d9d8a4f3f1faf4:da39a3ee5e6b4b0d3255bfef95601890afd80709#0ba8627bd47edc3a501e8f0eb9a79e5e - Download (conan-center)
    Skipped binaries
        bison/3.8.2, brotli/1.1.0, bzip2/1.0.8, double-conversion/3.3.0, expat/2.6.3, flex/2.6.4, fontconfig/2.15.0, freetype/2.13.2, gnu-config/cci.20210814, gperf/3.1, icu/74.2, libffi/3.4.4, libiconv/1.17, libjpeg/9e, libmysqlclient/8.1.0, libpng/1.6.44, libpq/15.4, libtool/2.4.7, libxml2/2.13.4, lz4/1.9.4, md4c/0.4.8, meson/1.2.2, meson/1.3.0, meson/1.3.2, meson/1.4.0, ninja/1.12.1, odbc/2.3.11, openssl/3.3.2, pcre2/10.42, pkgconf/2.1.0, sqlite3/3.46.1, util-linux-libuuid/2.39.2, wayland-protocols/1.33, wayland/1.22.0, xkbcommon/1.5.0, zlib/1.3.1, zstd/1.5.5
    ERROR: Missing binary: pcre2/10.42:3ad2a8f0588fa84c2c7e638193c099d49b433df1
    
    pcre2/10.42: WARN: Can't find a 'pcre2/10.42' package binary '3ad2a8f0588fa84c2c7e638193c099d49b433df1' for the configuration:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.version=11
    os=Linux
    [options]
    build_pcre2_16=True
    build_pcre2_32=True
    build_pcre2_8=True
    build_pcre2grep=True
    fPIC=True
    grep_support_callout_fork=True
    link_size=2
    shared=False
    support_jit=False
    with_bzip2=True
    with_zlib=True
    [requires]
    bzip2/1.0.Z
    zlib/1.3.Z
    
    ERROR: Missing prebuilt package for 'pcre2/10.42'. You can try:
        - List all available packages using 'conan list "pcre2/10.42:*" -r=remote'
        - Explain missing binaries: replace 'conan install ...' with 'conan graph explain ...'
        - Try to build locally from sources using the '--build=pcre2/10.42' argument
    
    More Info at 'https://docs.conan.io/2/knowledge/faq.html#error-missing-prebuilt-package'
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@ashley-b ashley-b force-pushed the fix/update_qwt_to_work_with_qt6 branch from ffd7240 to 5eab37d Compare November 4, 2024 12:29
@ashley-b ashley-b force-pushed the fix/update_qwt_to_work_with_qt6 branch from 5eab37d to 892d043 Compare November 19, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Failed Missing dependencies Build failed due missing dependencies in Conan Center
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants