Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clickhouse-cpp: use correct cityhash version #21689

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

clickhouse-cpp: use correct cityhash version #21689

wants to merge 1 commit into from

Conversation

PodnimatelPingvinov
Copy link
Contributor

@PodnimatelPingvinov PodnimatelPingvinov commented Dec 8, 2023 •
edited
Loading

Specify library name and version: clickhouse-cpp/*

Corresponding issue: #21688

@prince-chrismc prince-chrismc mentioned this pull request Dec 8, 2023
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot
Copy link
Collaborator

🚦 Thank for your Bump dependencies PR. The build service will be triggered soon by a Conan team member.

valgur
valgur approved these changes Mar 24, 2024
View reviewed changes
Copy link
Contributor

@valgur valgur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

I would also include a comment next to it to clarify the same point to avoid it getting bumped by accident in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valgur valgur valgur approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Waiting for CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PodnimatelPingvinov @conan-center-bot @valgur