Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lemon/3.32.3 recipe #2201

Merged
merged 10 commits into from
Aug 12, 2020
Merged

Add lemon/3.32.3 recipe #2201

merged 10 commits into from
Aug 12, 2020

Conversation

madebr
Copy link
Contributor

@madebr madebr commented Jul 14, 2020

Specify library name and version: lemon/3.32.3

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot
Copy link
Collaborator

Some configurations of 'lemon/3.32.3' failed in build 1 (88737891545847276cab908499d179dbf42729c6):

@conan-center-bot
Copy link
Collaborator

Some configurations of 'lemon/3.32.3' failed in build 2 (261817684c408658eaa5be455a1a361216cb61bd):

@conan-center-bot
Copy link
Collaborator

Some configurations of 'lemon/3.32.3' failed in build 3 (72fe23956e181e09dce02e475b8b06a89b68c941):

@conan-center-bot
Copy link
Collaborator

Some configurations of 'lemon/3.32.3' failed in build 4 (fe16920b564234bf16494b93642280d0c6d63cc1):

@conan-center-bot
Copy link
Collaborator

All green in build 5 (615b5cda4b165d04f0491ab6c86965079a29ed86)! 😊

@conan-center-bot
Copy link
Collaborator

All green in build 6 (8c8992a31f2f422f074f6efcfcb807c9c8be220e)! 😊

@conan-center-bot
Copy link
Collaborator

All green in build 7 (5690b0252d3d264ad0b07f7d132662fa726faa0f)! 😊

uilianries
uilianries previously approved these changes Jul 14, 2020
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@madebr
Copy link
Contributor Author

madebr commented Jul 14, 2020

@uilianries
Looks NOT good to me

See https://c3i.jfrog.io/c3i/misc/logs/pr/2201/7/lemon/3.32.3/ca33edce272a279b24f87dc0d4cf5bbdcffbc187/
It's built on MSVC in debug build_type using MTd runtime.

I'll have to remove the removal in package_id

SSE4
SSE4 previously approved these changes Jul 15, 2020
@madebr
Copy link
Contributor Author

madebr commented Jul 15, 2020

Please don't merge. CI builds debug packages!

@madebr madebr marked this pull request as draft July 15, 2020 10:49
@uilianries
Copy link
Member

@madebr thanks for checking! indeed it provided the wrong package again 😥

So, I think we will need to provide all settings again ...

@danimtb @jgsogo I think we need to revisit #1783 (comment). The current Windows package here didn't generate what we expected.

@madebr madebr dismissed stale reviews from SSE4 and uilianries via 474f19b July 16, 2020 18:47
@conan-center-bot
Copy link
Collaborator

An unexpected error happened and has been reported. Help is on its way! 🏇

@conan-center-bot
Copy link
Collaborator

All green in build 9 (474f19bfcac9e26cfa1f47995f9fcfbb8d8af1a1)! 😊

@conan-center-bot
Copy link
Collaborator

All green in build 10 (ba9309eb75328a04f5cdde4071a4c349d3c8362f)! 😊

@madebr madebr marked this pull request as ready for review July 19, 2020 21:47
@jgsogo
Copy link
Contributor

jgsogo commented Aug 5, 2020

I have a question. Do we want lemon to be an independent package or is it an executable that is distributed in the sqlite package? This will open the door to other tools/libraries packaged together... is this a path we want to walk?

@madebr
Copy link
Contributor Author

madebr commented Aug 5, 2020

I have a question. Do we want lemon to be an independent package or is it an executable that is distributed in the sqlite package? This will open the door to other tools/libraries packaged together... is this a path we want to walk?

Yes, lemon happens to be packaged in the same tarball as sqlite because the sqlite developers don't bother releasing it standalone.

For reference, fedora also packages lemon seperately, but they have the build script for lemon and sqlite combined.
The resulting packages don't have a dependency on eachother:
https://src.fedoraproject.org/rpms/sqlite/blob/master/f/sqlite.spec

Copy link
Contributor

@jgsogo jgsogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, lemon can be a different package, it's an isolated executable

@jgsogo jgsogo requested review from SSE4 and uilianries August 11, 2020 11:19
@jgsogo jgsogo merged commit 60bc873 into conan-io:master Aug 12, 2020
@madebr madebr deleted the lemon_recipe branch August 12, 2020 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants