-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
glibmm: add v2.78.0, drop static build support #22023
Conversation
This comment has been minimized.
This comment has been minimized.
Regenerating missing binaries now |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Conan v1 pipeline ✔️All green in build 1 (
Conan v2 pipeline ✔️
All green in build 1 ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, I think this is the way going forward :)
The support for static builds is quite broken out of the box for this library and the amount of patching required to add support for it seems excessive to me and are a maintenance headache. Especially the code-level patches, in light of the discussion at #17338.
I would have kept the excisting patches for older versions, but I don't think I can delete the
shared
andfPIC
options selectively without conflicting withpackage_type
.