Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glibmm: add v2.78.0, drop static build support #22023

Merged
merged 4 commits into from
Jul 2, 2024

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Dec 28, 2023

The support for static builds is quite broken out of the box for this library and the amount of patching required to add support for it seems excessive to me and are a maintenance headache. Especially the code-level patches, in light of the discussion at #17338.

I would have kept the excisting patches for older versions, but I don't think I can delete the shared and fPIC options selectively without conflicting with package_type.

@conan-center-bot

This comment has been minimized.

@AbrilRBS
Copy link
Member

AbrilRBS commented Jan 7, 2024

Regenerating missing binaries now

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Feb 12, 2024
@conan-center-bot conan-center-bot removed Failed stale Missing dependencies Build failed due missing dependencies in Conan Center labels Mar 19, 2024
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 1 (91ea193c5cd832b1e4d3fab8487fc69d6e2b8b57):

  • glibmm/2.66.4:
    All packages built successfully! (All logs)

  • glibmm/2.75.0:
    All packages built successfully! (All logs)

  • glibmm/2.72.1:
    All packages built successfully! (All logs)

  • glibmm/2.78.1:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 1 (91ea193c5cd832b1e4d3fab8487fc69d6e2b8b57):

  • glibmm/2.72.1:
    All packages built successfully! (All logs)

  • glibmm/2.66.4:
    All packages built successfully! (All logs)

  • glibmm/2.78.1:
    All packages built successfully! (All logs)

  • glibmm/2.75.0:
    All packages built successfully! (All logs)

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, I think this is the way going forward :)

@AbrilRBS AbrilRBS self-assigned this Jul 2, 2024
@conan-center-bot conan-center-bot merged commit ce1b1f5 into conan-io:master Jul 2, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants