tk: add v8.6.13

[valgur]

No description provided.

[Ahajha]

I found a few prior works, and it seems that the -ObjC flag is necessary when linking:
https://core.tcl-lang.org/tk/tktview/85f316beb15108ac43b03fa6c8608e31f3ae5f92
indygreg/PyOxidizer#613

I also have the new frameworks as well as the -ObjC flag conditional to the new version. It's possible those are added somewhere between 8.6.10 and 8.6.13, but for our purposes the condition should be fine.

(Will debug v2 tomorrow, unsure what happened here)

[Ahajha]

Not sure about the new error. It works on my machine(tm) but I have a newer OS and compiler, so it might be related to that. I've seen some suggestions but they mostly suggested modifying system settings, which doesn't seem like the right solution to me.

[Ahajha]

Really struggling to find what the cause of this, the only thread that seems to hint at anything remotely close to this problem is this one which suggests a bug in MacOS Ventura... But that's confusing as it works on my M2 with that OS (if I recall correctly). Not sure what Mac version the CCI runners are using.

[valgur]

Oh, wow. Nice job, @Ahajha. Thanks!

[Ahajha]

@valgur Just some context, essentially I found a function that does nothing if you pass in NULL. This mirrors a lot of what @jcar87 was saying in the recent protobuf PR about the test package being simple.

The only thing I don't like is that the weird runtime dependency on MacOS won't get caught by this package, maybe we can have it so that it uses the simple test only in CCI, so that at least it's caught locally?

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ valgur
✅ Ahajha
❌ Alex Trotta

---

Alex Trotta seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[Ahajha]

Not sure how to fix that... I must have been using another machine, but that's definitely me.

[valgur]

Not sure how to fix that... I must have been using another machine, but that's definitely me.

Force-pushing with the correct name / email should fix this.

[conan-center-bot]

Conan v1 pipeline ❌

Failure in build 13 (37829cb2561a6bc914a7e93a7e825415c89c209f):

• tk/8.6.13:
  CI failed to create some packages (All logs)

  Logs for packageID 49ec5528afd464ae0e73a717e8fa8e395916eb42:

  [settings]
  arch=armv8
  build_type=Debug
  compiler=apple-clang
  compiler.libcxx=libc++
  compiler.version=13.0
  os=Macos
  [options]
  tk:shared=False
  

  [...]
        _TkpDisplayWarning in libtk8.6.a(tkMacOSXInit.o)
        _StdinProc in libtk8.6.a(tkMain.o)
        _Prompt in libtk8.6.a(tkMain.o)
    "_Tcl_WriteObj", referenced from:
        _StdinProc in libtk8.6.a(tkMain.o)
        _Prompt in libtk8.6.a(tkMain.o)
        _TkCanvPostscriptCmd in libtk8.6.a(tkCanvPs.o)
    "_Tcl_WrongNumArgs", referenced from:
        _Tk_WmObjCmd in libtk8.6.a(tkMacOSXWm.o)
        _WmAspectCmd in libtk8.6.a(tkMacOSXWm.o)
        _WmAttributesCmd in libtk8.6.a(tkMacOSXWm.o)
        _WmClientCmd in libtk8.6.a(tkMacOSXWm.o)
        _WmColormapwindowsCmd in libtk8.6.a(tkMacOSXWm.o)
        _WmCommandCmd in libtk8.6.a(tkMacOSXWm.o)
        _WmDeiconifyCmd in libtk8.6.a(tkMacOSXWm.o)
        ...
    "_Tcl_ZlibCRC32", referenced from:
        _ReadData in libtk8.6.a(tkImgPNG.o)
        _ReadChunkHeader in libtk8.6.a(tkImgPNG.o)
        _ReadBase64 in libtk8.6.a(tkImgPNG.o)
        _ReadByteArray in libtk8.6.a(tkImgPNG.o)
        _WriteData in libtk8.6.a(tkImgPNG.o)
        _WriteIHDR in libtk8.6.a(tkImgPNG.o)
        _WriteChunk in libtk8.6.a(tkImgPNG.o)
        ...
    "_Tcl_ZlibStreamClose", referenced from:
        _CleanupPNGImage in libtk8.6.a(tkImgPNG.o)
    "_Tcl_ZlibStreamEof", referenced from:
        _DecodePNG in libtk8.6.a(tkImgPNG.o)
        _ReadIDAT in libtk8.6.a(tkImgPNG.o)
    "_Tcl_ZlibStreamGet", referenced from:
        _ReadIDAT in libtk8.6.a(tkImgPNG.o)
        _WriteIDAT in libtk8.6.a(tkImgPNG.o)
    "_Tcl_ZlibStreamInit", referenced from:
        _InitPNGImage in libtk8.6.a(tkImgPNG.o)
    "_Tcl_ZlibStreamPut", referenced from:
        _ReadIDAT in libtk8.6.a(tkImgPNG.o)
        _WriteIDAT in libtk8.6.a(tkImgPNG.o)
  ld: symbol(s) not found for architecture arm64e
  clang: error: linker command failed with exit code 1 (use -v to see invocation)
  make: *** [wish] Error 1
  WARN: **************************************************
  WARN: *** Conan 1 is legacy and on a deprecation path **
  WARN: *********** Please upgrade to Conan 2 ************
  WARN: **************************************************
  tk/8.6.13: ERROR: Package '49ec5528afd464ae0e73a717e8fa8e395916eb42' build failed
  tk/8.6.13: WARN: Build folder /Users/jenkins/workspace/prod-v1/bsr@2/102844/bcbdc/.conan/data/tk/8.6.13/_/_/build/49ec5528afd464ae0e73a717e8fa8e395916eb42/build-debug
  ERROR: tk/8.6.13: Error in build() method, line 220
  	autotools.make()
  	ConanException: Error 2 while executing make 'TCL_GENERIC_DIR=/Users/jenkins/workspace/prod-v1/bsr@2/102844/bcbdc/.conan/data/tcl/8.6.13/_/_/package/a60d991f22cb90dbf618e728b0ca8fd8f77d9c42/include' -j8
  

• tk/8.6.10:
  Didn't run or was cancelled before finishing

---

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

---

Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

Failure in build 13 (37829cb2561a6bc914a7e93a7e825415c89c209f):

• tk/8.6.13:
  CI failed to create some packages (All logs)

  Logs for packageID bd2d723bcd6b0ed67efe26dca8d26e49a550316e:

  [settings]
  arch=armv8
  build_type=Release
  compiler=apple-clang
  compiler.cppstd=17
  compiler.libcxx=libc++
  compiler.version=13
  os=Macos
  [options]
  */*:shared=False
  

  [...]
        ...
    "_Tcl_Write", referenced from:
        _WriteToChannel in libtk8.6.a(tkImgGIF.o)
        _WriteData in libtk8.6.a(tkImgPNG.o)
        _FileWritePPM in libtk8.6.a(tkImgPPM.o)
    "_Tcl_WriteChars", referenced from:
        _TkpDisplayWarning in libtk8.6.a(tkMacOSXInit.o)
        _StdinProc in libtk8.6.a(tkMain.o)
        _Prompt in libtk8.6.a(tkMain.o)
    "_Tcl_WriteObj", referenced from:
        _StdinProc in libtk8.6.a(tkMain.o)
        _Prompt in libtk8.6.a(tkMain.o)
        _TkCanvPostscriptCmd in libtk8.6.a(tkCanvPs.o)
    "_Tcl_WrongNumArgs", referenced from:
        _Tk_WmObjCmd in libtk8.6.a(tkMacOSXWm.o)
        _TkUnsupported1ObjCmd in libtk8.6.a(tkMacOSXWm.o)
        _TkMacOSXGetAppPathCmd in libtk8.6.a(tkMacOSXInit.o)
        _TkMacOSXStandardAboutPanelObjCmd in libtk8.6.a(tkMacOSXDialog.o)
        _Tk_MenuObjCmd in libtk8.6.a(tkMenu.o)
        _MenuWidgetObjCmd in libtk8.6.a(tkMenu.o)
        _Tk_GetScrollInfoObj in libtk8.6.a(tkUtil.o)
        ...
    "_Tcl_ZlibCRC32", referenced from:
        _ReadData in libtk8.6.a(tkImgPNG.o)
        _ReadChunkHeader in libtk8.6.a(tkImgPNG.o)
        _EncodePNG in libtk8.6.a(tkImgPNG.o)
        _WriteData in libtk8.6.a(tkImgPNG.o)
    "_Tcl_ZlibStreamClose", referenced from:
        _CleanupPNGImage in libtk8.6.a(tkImgPNG.o)
    "_Tcl_ZlibStreamEof", referenced from:
        _DecodePNG in libtk8.6.a(tkImgPNG.o)
    "_Tcl_ZlibStreamGet", referenced from:
        _DecodePNG in libtk8.6.a(tkImgPNG.o)
        _EncodePNG in libtk8.6.a(tkImgPNG.o)
    "_Tcl_ZlibStreamInit", referenced from:
        _FileMatchPNG in libtk8.6.a(tkImgPNG.o)
        _InitPNGImage in libtk8.6.a(tkImgPNG.o)
    "_Tcl_ZlibStreamPut", referenced from:
        _DecodePNG in libtk8.6.a(tkImgPNG.o)
        _EncodePNG in libtk8.6.a(tkImgPNG.o)
  ld: symbol(s) not found for architecture arm64e
  clang: error: linker command failed with exit code 1 (use -v to see invocation)
  make: *** [wish] Error 1
  
  tk/8.6.13: ERROR: 
  Package 'bd2d723bcd6b0ed67efe26dca8d26e49a550316e' build failed
  tk/8.6.13: WARN: Build folder /Users/jenkins/workspace/prod-v2/bsr@2/91588/bfbce/p/b/tk00fdf236ecd07/b/build-release
  ERROR: tk/8.6.13: Error in build() method, line 220
  	autotools.make()
  	ConanException: Error 2 while executing
  

• tk/8.6.10:
  Didn't run or was cancelled before finishing

---

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

[Ahajha]

@valgur I think there was a part of that reverted commit that's still necessary. I'll try to fix the CLA problem.

[valgur]

@Ahajha I already overwrote the author and force-pushed that commit, so the CLA issue should be fixed. The CLA check is having issues in all PRs today, it looks like, so it has not updated the status yet.

[Ahajha]

@valgur When you get a chance could you try to fix the author for the three earlier commits? I tried just now and got some unrelated merge conflicts that I'm not sure how to fix. I want to try to get this merged since 8.6.15 and 9.0 are out now.

Not super important, but I realized that those commits were using my old work email which I don't have access to anymore.