-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor boost/test_package to make it pass on Linux #2205
Refactor boost/test_package to make it pass on Linux #2205
Conversation
Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue. |
What does not work on Linux? Can you post some logs? |
@klimkin why is it failing in Linux? are your cross-building? Could you give us more information about the changes? |
The change solves this error:
After change:
Note from FindBoost.cmake of CMake 3.15.2:
|
f6f472e
to
b59a565
Compare
Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue. |
@klimkin cmake.definitions["Boost_ADDITIONAL_VERSIONS"] = self.deps_cpp_info["boost"].version to A few hours ago, I added similar patches for fixing python and numpy. I have currently a pr open about adding component support to the boost recipe at #2097. Both changes have been made to the test_package. |
|
An unexpected error happened and has been reported. Help is on its way! 🏇 |
Some configurations of 'boost/1.69.0' failed in build 4 (
|
b59a565
to
2140044
Compare
An unexpected error happened and has been reported. Help is on its way! 🏇 |
Some configurations of 'boost/1.69.0' failed in build 6 (
|
|
3bb5f4e
to
ccbe42e
Compare
Failure in build 7 (
|
I didn't change conandata.yml and my hooks are quiet. Why the errors? |
Ok, I see this now. |
8eb26ec
to
bb13208
Compare
An unexpected error happened and has been reported. Help is on its way! 🏇 |
Some configurations of 'boost/1.66.0' failed in build 9 (
|
bb13208
to
528d3e5
Compare
Some configurations of 'boost/1.69.0' failed in build 10 (
|
Yes, the failures in Windows are expected. Boost build with MT runtime and shared configuration produces nothing and does not error de build. This configuration is not supported by boost and should be skipped (it was recently added to ConanCenter). |
Thank you for the comment! Anything else I can do to help this request? |
we should add those settings as invalid configurations in the boost recipe |
528d3e5
to
3ffb854
Compare
An unexpected error happened and has been reported. Help is on its way! 🏇 |
Propagate Python version to the test scripts.
3ffb854
to
1c3384d
Compare
All green in build 12 (
|
@uilianries could you review, please? |
Refactor and fix boost test_package for Linux
Specify library name and version: boost/1.73.0
conan-center hook activated.