Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbus: fix build of 1.15.8 with Visual Studio 2022 #22156

Conversation

tsondergaard
Copy link
Contributor

@tsondergaard tsondergaard commented Jan 4, 2024

Instead of using has_header use check_header to confirm the header works. This is necessary to get the meson build to work with Visual Studio 2022. It has <stdatomic.h> but it does not actually work when compiling a C program.

Fixes #19421

See also associated upstream issue and merge request:

Specify library name and version: dbus/1.15.8


Instead of using has_header use check_header to confirm the header
works. This is necessary to get the meson build to work with Visual
Studio 2022. It has <stdatomic.h> but it does not actually work when
compiling a C program.

Fixes conan-io#19421
Copy link
Contributor

github-actions bot commented Jan 4, 2024

🤖 Beep Boop! This pull request is making changes to 'recipes/dbus//'.

👋 @jwillikers you might be interested. 😉

@ghost
Copy link

ghost commented Jan 4, 2024

I detected other pull requests that are modifying dbus/1.x.x recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

@jwillikers jwillikers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for working on a fix upstream.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 2 (2a9a6ce9263bcb9ea1f3a592e9552f25636617e6):

  • dbus/1.15.8:
    All packages built successfully! (All logs)

  • dbus/1.15.6:
    All packages built successfully! (All logs)

  • dbus/1.15.0:
    All packages built successfully! (All logs)

  • dbus/1.15.2:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 2 (2a9a6ce9263bcb9ea1f3a592e9552f25636617e6):

  • dbus/1.15.8:
    All packages built successfully! (All logs)

  • dbus/1.15.0:
    All packages built successfully! (All logs)

  • dbus/1.15.2:
    All packages built successfully! (All logs)

  • dbus/1.15.6:
    All packages built successfully! (All logs)

@AbrilRBS AbrilRBS self-assigned this Jan 5, 2024
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's wait for upstream decision on merging their PR before merging this one, please ping me when the PR is updated, thanks! :)

@tsondergaard
Copy link
Contributor Author

Thanks! Let's wait for upstream decision on merging their PR before merging this one, please ping me when the PR is updated, thanks! :)

@RubenRBS, the upstream PR has been merged. Will you approve this PR now?

Once approved do I need to update the branch? The CI comment says "This branch is out-of-date with the base branch" next to a warning icon, but it is not clear to me if this is just a warning or an issue that needs to be addressed before the PR can be merged automatically.

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

but it is not clear to me if this is just a warning or an issue that needs to be addressed before the PR can be merged automatically.

It's just GitHub's way to notify contributors that changes arrived in the main branch not present in this PR, but nothing to worry about unless it also shows that there are conflcits!

Approved, thanks a lot! :)

@conan-center-bot conan-center-bot merged commit f145f35 into conan-io:master Jan 16, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[package] dbus/1.15.8: compilation fails with Visual Studio 2022 (and C++20?)
4 participants