-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qtawesome: add v6.5.1 #22369
base: master
Are you sure you want to change the base?
qtawesome: add v6.5.1 #22369
Conversation
This comment has been minimized.
This comment has been minimized.
7163698
to
89e946c
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@@ -72,7 +72,7 @@ def validate(self): | |||
raise ConanInvalidConfiguration( | |||
f"{self.ref} requires C++{self._min_cppstd}, which your compiler does not support." | |||
) | |||
if self.settings.os == "Linux": | |||
if self.version == "6.4.0" and self.settings.os == "Linux": | |||
raise ConanInvalidConfiguration("Linux is not supported yet") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if Linux is not also supported by the 6.4.0.
|
||
def package_info(self): | ||
self.cpp_info.libs = ["QtAwesome"] | ||
if Version(self.version) >= "6.5": | ||
self.cpp_info.includedirs.append(os.path.join("include", "QtAwesome")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure it is needed ?
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ❌Failure in build 5 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping Failure in build 5 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
No description provided.