Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-c-sdkutils: add v0.1.13, use version range for dependencies #22406

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

st9007a
Copy link
Contributor

@st9007a st9007a commented Jan 17, 2024

Specify library name and version: aws-c-sdkutils/0.1.13

Update this dependency because I want to update aws-crt-cpp to the latest version. Here are related issues:

The version range is based on the submodules used in aws-crt-cpp. I wrote a script to collect the version mapping between aws-c-sdkutils and aws-c-common. In the following mapping, keys are the versions of aws-c-sdkutils and values are the versions of was-c-common.

{
  'v0.1.10': {'v0.8.21'},
  'v0.1.11': {'v0.9.3', 'v0.9.0', 'v0.8.23'},
  'v0.1.12': {'v0.9.10', 'v0.9.4', 'v0.9.7', 'v0.9.9'},
  'v0.1.13': {'v0.9.12', 'v0.9.10'},
  'v0.1.7': {'v0.8.12'},
  'v0.1.8': {'v0.8.17', 'v0.8.15'},
  'v0.1.9': {'v0.8.19'},
}

The change of version range in this PR is based on it.


@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

@valgur valgur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for the version range use. It is only allowed for a small set of packages on CCI currently, like libcurl and zlib.

@st9007a
Copy link
Contributor Author

st9007a commented Mar 25, 2024

LGTM, except for the version range use. It is only allowed for a small set of packages on CCI currently, like libcurl and zlib.

Hi @valgur ,

Thanks for your review. Could you guide me any suggestion to use version range here ?

self.requires("aws-c-common/0.8.2", transitive_headers=True, transitive_libs=True)
elif Version(self.version) == "0.1.12":
self.requires("aws-c-common/[>=0.9.4 <=0.9.10]", transitive_headers=True, transitive_libs=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
self.requires("aws-c-common/[>=0.9.4 <=0.9.10]", transitive_headers=True, transitive_libs=True)
# [>=0.9.4 <=0.9.10]
self.requires("aws-c-common/0.9.10", transitive_headers=True, transitive_libs=True)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out. I made the change accordingly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a minor difference. Because the current recipe of was-c-common doesn't have 0.9.10, I use 0.9.6 here.

else:
self.requires("aws-c-common/0.9.6", transitive_headers=True, transitive_libs=True)
self.requires("aws-c-common/[>=0.9.10]", transitive_headers=True, transitive_libs=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
self.requires("aws-c-common/[>=0.9.10]", transitive_headers=True, transitive_libs=True)
# [>=0.9.10]
self.requires("aws-c-common/0.9.12", transitive_headers=True, transitive_libs=True)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out. I made the change accordingly.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 2 (c1a874e858430ddd604004372ca2ede8d75e184d):

  • aws-c-sdkutils/0.1.13:
    All packages built successfully! (All logs)

  • aws-c-sdkutils/0.1.12:
    All packages built successfully! (All logs)

  • aws-c-sdkutils/0.1.3:
    All packages built successfully! (All logs)

  • aws-c-sdkutils/0.1.2:
    All packages built successfully! (All logs)

  • aws-c-sdkutils/0.1.1:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 2 (c1a874e858430ddd604004372ca2ede8d75e184d):

  • aws-c-sdkutils/0.1.13:
    All packages built successfully! (All logs)

  • aws-c-sdkutils/0.1.3:
    All packages built successfully! (All logs)

  • aws-c-sdkutils/0.1.2:
    All packages built successfully! (All logs)

  • aws-c-sdkutils/0.1.1:
    All packages built successfully! (All logs)

  • aws-c-sdkutils/0.1.12:
    All packages built successfully! (All logs)

@perseoGI perseoGI self-assigned this Jul 29, 2024
@danimtb danimtb requested a review from perseoGI July 31, 2024 08:45
Copy link
Contributor

@perseoGI perseoGI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but in a future it will be good to handle version mappings from conandata.yml to avoid regeneration of new revisions

@conan-center-bot conan-center-bot merged commit 6837af9 into conan-io:master Jul 31, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants