Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[protobuf] Revert "improve discovery of protoc executable in build context" #22542

Closed
wants to merge 2 commits into from

Conversation

uilianries
Copy link
Member

The PR #20089 is causing side-effects listed in the issue #21737 and is blocking #22244

fixes #21737

Copy link
Contributor

🤖 Beep Boop! This pull request is making changes to 'recipes/protobuf//'.

👋 @Hopobcn you might be interested. 😉

@uilianries uilianries requested a review from AbrilRBS January 25, 2024 15:52
@uilianries uilianries self-assigned this Jan 25, 2024
@ghost
Copy link

ghost commented Jan 25, 2024

I detected other pull requests that are modifying protobuf/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor

SpaceIm commented Jan 25, 2024

Please no, openvino recipe is likely broken since it's missing protobuf in build requirements in case of native build. It was working by luck. Issues reported in #21737 are unclear and missing proper issue template informations to investigate.

@ilya-lavrenov
Copy link
Contributor

Please no, openvino recipe is likely broken since it's missing protobuf in build requirements in case of native build. It was working by luck. Issues reported in #21737 are unclear and missing proper issue template informations to investigate.

Thanks, let's check #22289

@SpaceIm
Copy link
Contributor

SpaceIm commented Jan 25, 2024

Could you try exactly what is suggested in #22244 (comment) please?

  • VirtualBuildEnv since there are build requirements (implicit with conan v2 client, but not with conan v1 client)
  • Do not add protobuf & flatbuffers to build requirements if 1 profile (due to potential issues in conan v1 in case of dependencies of these libs overridden by users).
  • VirtualRunEnv in build scope if 1 profile

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 2 (0b0735ea549ee77bacccc869055a89c8f122254a):

  • protobuf/3.21.12:
    All packages built successfully! (All logs)

  • protobuf/3.21.9:
    All packages built successfully! (All logs)

  • protobuf/3.20.0:
    All packages built successfully! (All logs)

  • protobuf/3.18.3:
    All packages built successfully! (All logs)

  • protobuf/3.19.6:
    All packages built successfully! (All logs)

  • protobuf/3.17.1:
    All packages built successfully! (All logs)

  • protobuf/3.20.3:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 2 (0b0735ea549ee77bacccc869055a89c8f122254a):

  • protobuf/3.21.12:
    All packages built successfully! (All logs)

  • protobuf/3.21.9:
    All packages built successfully! (All logs)

  • protobuf/3.20.0:
    All packages built successfully! (All logs)

  • protobuf/3.20.3:
    All packages built successfully! (All logs)

  • protobuf/3.19.6:
    All packages built successfully! (All logs)

  • protobuf/3.17.1:
    All packages built successfully! (All logs)

  • protobuf/3.18.3:
    All packages built successfully! (All logs)

@uilianries uilianries marked this pull request as draft January 26, 2024 12:39
@ilya-lavrenov
Copy link
Contributor

Looks like it can be closed

@uilianries
Copy link
Member Author

Closing this issue as the PR #22244 is no longer blocked after updating protobuf usage.

@uilianries uilianries closed this Jan 30, 2024
@AbrilRBS AbrilRBS deleted the revert-20089-fix/protobuf-find-protoc branch September 25, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

protobuf recent update broke protoc integration
5 participants