[boost] Add default support to C++11 #22554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
|
🤖 Beep Boop! This pull request is making changes to 'recipes/boost//'. 👋 @grafikrobot @Hopobcn @jwillikers you might be interested. 😉 |
Signed-off-by: Uilian Ries <uilianries@gmail.com>
This was referenced Jan 26, 2024
|
Hola @grafikrobot ! Please, take a look in this change if possible. It changes how we pass the |
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 2fedc72boost/1.82.0@#c5238cf2ff89472f878a9cb32b3e8202boost/1.81.0@#663565e59746dfa3d9b15b40b0c93223boost/1.84.0@#14a3c84208e6440e1f4e02e04e65a07aboost/1.74.0@#1978fc0376beb50cedcb6ecee5f98021boost/1.83.0@#d723c467c390230ad0abd1df0d3ddd36boost/1.77.0@#2bc84a3c4496c607555699e9149b0bd8boost/1.80.0@#c88efaeb4cafd9f0819b300f74e93552boost/1.79.0@#2a0ef5ea0c5ad8c7d31518900182fb8aboost/1.78.0@#c9d61849b0115809573eae30057c7dd0boost/1.72.0@#21539ff2739c9bda2b09f95338342f1eboost/1.76.0@#ef7ae94c5c3e86f05ba026568b46e73eboost/1.75.0@#e2e473c08e4ba5ebd920b2569177fa49boost/1.73.0@#fec07318f8c4fe017956e90ff43a7ab5boost/1.71.0@#760210868c29c9814dc2c977d9bd1934 |
grafikrobot
suggested changes
Jan 27, 2024
recipes/boost/all/conanfile.py
Outdated
| @@ -1098,6 +1105,9 @@ def add_defines(library): | |||
| if self.settings.get_safe("compiler.cppstd"): | |||
| cppstd_flag = AutotoolsToolchain(self).cppstd | |||
| flags.append(f"cxxflags={cppstd_flag}") | |||
| elif self._has_cppstd_11_supported: | |||
| prefix = "/" if is_msvc(self) else "-" | |||
| flags.append(f"cxxflags={prefix}std=c++11") | |||
There was a problem hiding this comment.
You should be using the cxxstd feature instead of adding compiler specific flags. Add a cxxstd=11 argument to the invocation.
There was a problem hiding this comment.
PS. If it's not already the case.. The recipe should pass in cxxstd=XY for all the other compiler.cppstd values.
There was a problem hiding this comment.
Thank you! I'll update it.
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 7 (
|
Hooks produced the following warnings for commit 8c70266boost/1.84.0@#695713218cdeec6aef61de1f34bf57eeboost/1.83.0@#67abd9a563219045b609c298bccb8f42boost/1.82.0@#c7d44b59c1738ecd5db1679ed58e9ce7boost/1.71.0@#108a46288f3afbb8a6418b6edc7e2adbboost/1.72.0@#0abaac50c6785a715ea897b91d71cbd4boost/1.78.0@#eea1d003ed2400b519cadad2e17804b5boost/1.81.0@#753df9d4f149a5551335f47abe21de0bboost/1.79.0@#b30f1da8799cc25469e6aad9a4c02f74boost/1.80.0@#f37f3526974fd35657763a4ac0959b89boost/1.75.0@#cdb751a26a5fcc0c1be04cb3eb11d528boost/1.77.0@#40dff68ce0d38e07fd8609f754bf84d4boost/1.74.0@#6841bd73e1464d8cba6b01bd8794547dboost/1.73.0@#2680a5dc1dd7fd2b1dea96fb7788d4e2boost/1.76.0@#a5984ca48a8b55a70c6cc5178df97014 |
jwillikers
approved these changes
Jan 30, 2024
grafikrobot
approved these changes
Jan 30, 2024
ghost
mentioned this pull request
3 tasks
franramirez688
approved these changes
Feb 1, 2024
3 tasks
Ahajha
pushed a commit
to Ahajha/conan-center-index
that referenced
this pull request
Feb 10, 2024
* Add support to C++11 Signed-off-by: Uilian Ries <uilianries@gmail.com> * update tests Signed-off-by: Uilian Ries <uilianries@gmail.com> * update more tests with c++11 Signed-off-by: Uilian Ries <uilianries@gmail.com> * apple clang still does not suport c++11 by default Signed-off-by: Uilian Ries <uilianries@gmail.com> * Use correct cxxstd flag with b2 Signed-off-by: Uilian Ries <uilianries@gmail.com> * format nothing in string Signed-off-by: Uilian Ries <uilianries@gmail.com> --------- Signed-off-by: Uilian Ries <uilianries@gmail.com> Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
This was referenced Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Boost 1.84.0, basic boost libraries like atomic, filesystem, log, random, thread and test require C++11 (see https://www.boost.org/users/history/version_1_84_0.html), making impossible to build without a
settings.compiler.cppstddefined when using apple-clang < 14.The apple-clang compiler uses C++98 as its standard until version 14, so without
settings.compiler.cppstd, this recipe would use the default c++ standard supported by the compiler instead.However, apple-clang supports C++11 since many years ago. Plus, in Conan 1.x is not defined a cppstd by default, even in ConanCenterIndex, it would make impossible to generate new package into Conan Center.
This PR injects
-std=c++11to cxxflags in case there is NOsettings.compiler.cppstddefined AND the compiler supports it (see supported_cppstd)fixes #22522
/cc @patmantru