async_simple: add 1.3, reinstate msvc, add compiled version #22614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uthread on non-windows
ghost
mentioned this pull request
|
I detected other pull requests that are modifying async_simple/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
Don't rename if .a name is already libasync_simple.a (like it is in 1.0)
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit cc284b9async_simple/1.3@#c91de1eca5d26289d77ed9fbe171b397async_simple/1.0.0@#52ea8dcc1ca7602e0a2760c88e1fa7c5 |
valgur
approved these changes
Mar 24, 2024
danimtb
previously approved these changes
Apr 10, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit ad94d03async_simple/1.2@#75ebce7082b57891db6bc2422606453e |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit da3834casync_simple/1.0.0@#a0bc3185256a1484deeec098f0994a52 |
This comment has been minimized.
This comment has been minimized.
danimtb
approved these changes
Apr 22, 2024
danimtb
requested changes
Apr 25, 2024
There was a problem hiding this comment.
Waiting for answer and requested changes at #22614 (comment)
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
uilianries
reviewed
Apr 29, 2024
| if not self.options.header_only: | ||
| hCopyExcludes = ("test", "executors") | ||
| if self.options.shared: | ||
| copy(self, pattern="*.so*", |
There was a problem hiding this comment.
Mac generates .dylib, not .so. The current validate supports mac as well.
This comment has been minimized.
This comment has been minimized.
danimtb
previously approved these changes
Apr 30, 2024
AbrilRBS
reviewed
May 9, 2024
Comment on lines
93
to
94
| deps = CMakeDeps(self) | ||
| deps.generate() |
There was a problem hiding this comment.
Suggested change
| deps = CMakeDeps(self) | |
| deps.generate() |
not needed, as the recipe has no requirements
| if minimum_version and Version(self.settings.compiler.version) < minimum_version: | ||
| raise ConanInvalidConfiguration(f"{self.ref} requires C++{self._min_cppstd}, which your compiler does not support.") | ||
| if not self.options.header_only and self.settings.os == "Windows": | ||
| raise ConanInvalidConfiguration(f"{self.ref} cannot use uthread on Windows, and therefore should only be header_only") |
There was a problem hiding this comment.
Suggested change
| raise ConanInvalidConfiguration(f"{self.ref} cannot use uthread on Windows, and therefore should only be header_only") | |
| raise ConanInvalidConfiguration(f'{self.ref} cannot use uthread on Windows, and therefore it's only supported as a header-only library in this configuration with "{self.name}/*:header_only=True"') |
Make invalid configuration message nicer
Conan v1 pipeline ✔️All green in build 10 (
Conan v2 pipeline ✔️
All green in build 9 ( |
danimtb
approved these changes
May 9, 2024
jwillikers
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: async_simple/1.3
This quite heavily modifies the recipe to support non-header-only-mode (only on not windows, since the only reason to compile it is for uthread, which only works on linux and osx)
It also removes the invalid throw on msvc - not sure why it was there in the first place, even 1.0 appears to work fine in msvc.
And finally, it adds the latest just released version, 1.3