Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glm: add version 1.0.0 #22657

Closed
wants to merge 4 commits into from
Closed

Conversation

StellaSmith
Copy link
Contributor

g-truc/glm#1226

The released archive has a bit of a different structure than previous releases, so i had to add some conditionals for v1.0.0.
I'm wondering if I should also delete the cci.yyyymmdd versions and/or create a different subfolder for this release.

@CLAassistant
Copy link

CLAassistant commented Feb 5, 2024

CLA assistant check
All committers have signed the CLA.

@StellaSmith StellaSmith changed the title add glm/1.0.0 glm: add version 1.0.0 Feb 5, 2024
@conan-center-bot

This comment has been minimized.

@StellaSmith
Copy link
Contributor Author

I decided in the end to remove the older versions to simplify the conanfile, as i also believe that the cci versions are not necessary anymore that there's an official release.

@conan-center-bot

This comment has been minimized.

@AbrilRBS AbrilRBS self-assigned this Feb 6, 2024
@conan-center-bot

This comment has been minimized.

@uilianries
Copy link
Member

@StellaSmith Please, don't forget to update the config.yml as well.

@StellaSmith
Copy link
Contributor Author

@StellaSmith Please, don't forget to update the config.yml as well.

😅 i did this at like 2 am so i forgot

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 4 (d95bc1f4c64958ab70a32bb322513696279d1a1c):

  • glm/1.0.0:
    All packages built successfully! (All logs)

  • glm/0.9.9.8:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 4 (d95bc1f4c64958ab70a32bb322513696279d1a1c):

  • glm/1.0.0:
    All packages built successfully! (All logs)

  • glm/0.9.9.8:
    All packages built successfully! (All logs)

@TheHugeManatee
Copy link
Contributor

Hi everyone!
Came here when looking to do the same thing as @StellaSmith , as I was looking for an up-to-date version of this lib.
Any way I can pitch in to get this moved along? There's a version 1.0.1 at this point as well, not sure if that's easier done in a later PR:

https://github.com/g-truc/glm/releases/tag/1.0.1

@valgur
Copy link
Contributor

valgur commented Apr 19, 2024

@StellaSmith Could you replace the v1.0.0 in this PR with v1.0.1, please.

@RubenRBS a review would be welcome. It's a pretty small PR.

@TheHugeManatee
Copy link
Contributor

Hi @valgur,
Since there's no activity from the original PR author, is it reasonable that I create a new PR with the requested changes (v1.0.1)? If so, could I fork @StellaSmith 's cci fork and create a PR to here, or would that somehow violate the CLA? Or is there simpler way that I can take over the required updates?

@valgur
Copy link
Contributor

valgur commented Apr 24, 2024

@TheHugeManatee Yes, that should be perfectly fine since they have signed the CLA. Feel free to open a new PR based off these commits.

@TheHugeManatee TheHugeManatee mentioned this pull request Apr 24, 2024
3 tasks
@TheHugeManatee
Copy link
Contributor

Thanks for the quick feedback! I created a new PR here: #23742 . I guess this one can be closed then.

@perseoGI
Copy link
Contributor

I'm closing this PR in favor of this one already merged #23742
which adds a newer version (v1.0.1)

Thanks!

@perseoGI perseoGI closed this Jul 24, 2024
Jak-o-Shadows added a commit to Jak-o-Shadows/conan-center-index that referenced this pull request Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants