Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nlohmann_json: add 3.9.0 (and implicit_conversions option) #2279

Merged
merged 1 commit into from
Jul 28, 2020
Merged

nlohmann_json: add 3.9.0 (and implicit_conversions option) #2279

merged 1 commit into from
Jul 28, 2020

Conversation

theodelrieu
Copy link
Contributor

@theodelrieu theodelrieu commented Jul 27, 2020 •
edited
Loading

Specify library name and version: nlohmann_json/3.9.0

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot
Copy link
Collaborator

All green in build 1 (7924e70b2ed9a6452f0557cbf7d6bd805750195a)! 😊

uilianries
uilianries requested changes Jul 27, 2020
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost good to go. Please, update config.yml too.

@conan-center-bot
Copy link
Collaborator

All green in build 2 (9c973efa1d0cfe52b9d033d2e15366fa005e7c80)! 😊

uilianries
uilianries approved these changes Jul 27, 2020
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uilianries uilianries requested review from danimtb and SSE4 July 27, 2020 18:47
@danimtb danimtb merged commit a04ca30 into conan-io:master Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prince-chrismc prince-chrismc prince-chrismc approved these changes

@danimtb danimtb danimtb approved these changes

@uilianries uilianries uilianries approved these changes

@SSE4 SSE4 SSE4 approved these changes

Assignees

@danimtb danimtb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@theodelrieu @conan-center-bot @SSE4 @uilianries @danimtb @prince-chrismc