-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: libq #22828
New package: libq #22828
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thanks a lot for taking the time to contribute the recipe, we really appreciate it!
I've left some comments on the minor changes, but I'd suggest looking into the CMake package template https://github.com/conan-io/conan-center-index/tree/master/docs/package_templates/cmake_package - basing the recipe off of this should be straightforward and will take care of some the pitfalls I've mentioned and most which I didn't :)
Let me know if you need any help with that
recipes/libq/all/conanfile.py
Outdated
class libqConan(ConanFile): | ||
name = "libq" | ||
description = "A platform-independent promise library for C++, implementing asynchronous continuations." | ||
license = "Apache license 2.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a spdx identifier listed https://spdx.org/licenses/
license = "Apache license 2.0" | |
license = "Apache-2.0" |
This comment has been minimized.
This comment has been minimized.
Hello, I think I managed to update it based on the template. Thank for the review! |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I don't get why it says libq not found in package in the test package. |
…-index.git into package/libq
This comment has been minimized.
This comment has been minimized.
Thank you for the review, I applied your changes, it looks good now I think 👍 |
Co-authored-by: Uilian Ries <uilianries@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @metalMajor I made some changes to get Windows building at least as static. Now the only remaing hurdle for this PR to solve comes from the CLA bot, #22828 (comment) says that there is at least one commit authored by a different author, who would need to also sign it (Or for the commit to be rebased with a different author) |
The use |
I think it is solved, I removed an email address, now I put it back. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for taking the time to get the PR thru the finish line, and thanks for your patience while we got it reviewed, we appreciate it :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for your PR!
Awesome! |
Co-authored-by: Uilian Ries <uilianries@gmail.com> Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
Co-authored-by: Uilian Ries <uilianries@gmail.com> Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
Specify library name and version: libq/20180504
I am not the creator of the library, but I am using this library for a while now, mostly in combination with libcurl to interact with a backend webserver, and wanted to hopefully promote some interest in the library by providing this package. The original author does not update it anymore it seems, but it's quite stable. Because the author never really officially released a 1.0, but mentions that the api would not change anymore before 1.0, I have used the date of the commit from which I created this package instead of 1.0.