-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stdgpu: fix CUDA and HIP custom CMake modules #22851
base: master
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
target_link_libraries() cannot be used with imported targets in some cases.
824c542
to
edd675b
Compare
Conan v1 pipeline ✔️All green in build 3 (
Conan v2 pipeline ✔️
All green in build 3 ( |
@valgur Thank you for your PR, could please update this PR description with more information? What's trying to fix, do you have a build log? The current PR does not targets an issue or more detailed case. |
@uilianries Before applying valgur/cupoch@1f173b8 the build failed with
|
@valgur Which build? I don't find any other issue or PR related to stdgpu. The past PR for stdgpu in CCI did not fail to link cmake targets in test package. Please, add details about the error, you can use the issue template. As we are using a custom cmake file, it could be used as information for similar cases in CCI. Please, always add context and details in the PR description. |
target_link_libraries()
cannot be used with imported targets in some cases.