Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miniscript: add version 1.6.2 #22861

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Conversation

toge
Copy link
Contributor

@toge toge commented Feb 22, 2024

Specify library name and version: miniscript/1.6.2

  • follow library names in 1.5.1
  • use upstream CMakeLists.tt in 1.6.2
  • follow API changes since 1.6.2

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@AbrilRBS AbrilRBS self-assigned this Feb 26, 2024
@AbrilRBS
Copy link
Member

Dum dum CI did not post the results, sorry about that. Restarting v1, but v2 failed https://c3i.jfrog.io/c3i/misc-v2/summary.html?json=https://c3i.jfrog.io/c3i/misc-v2/logs/pr/22861/6-windows-msvc/miniscript/1.5.1//summary.json for a proper reason

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@uilianries
Copy link
Member

Hello @toge The version 1.6.2 has a CMakeLists.txt supported: https://github.com/JoeStrout/miniscript/blob/v1.6.2/CMakeLists.txt

Is is not enough to build the project?

@toge
Copy link
Contributor Author

toge commented Mar 4, 2024

@uilianries
Hello uilianries.
Thanks you for your review.

I know that.
If version is 1.6.2, this recipe tries to use CMakeLists.txt from upstream.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

perseoGI
perseoGI previously approved these changes Jul 29, 2024
Co-authored-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot

This comment has been minimized.

Co-authored-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

Warning

Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement.

All green in build 5 (5dc6d39037d9ebb0c20b05400bfe956bd8db9caa):

  • miniscript/1.5.1:
    Built 20 packages out of 22 (All logs)

  • miniscript/1.6.2:
    Built 16 packages out of 22 (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 5 (5dc6d39037d9ebb0c20b05400bfe956bd8db9caa):

  • miniscript/1.6.2:
    Built 8 packages out of 10 (All logs)

  • miniscript/1.5.1:
    Built 8 packages out of 10 (All logs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants