New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dispenso: Add new recipe #22876

Merged

conan-center-bot merged 11 commits into conan-io:master from AbrilRBS:rr/add-dispenso

May 14, 2024

Member

AbrilRBS commented Feb 24, 2024 •

edited

Loading

Specify library name and version: dispenso/1.3.0

Initially tried to add 1.2, but after testing it, it did not build for Linux under Docker, reported as [Bug]: warn_unused_result compilation error in dispenso/priority.cpp for Linux facebookincubator/dispenso#27 upstream - Decided to move to 1.3 after it got fixed there


First sketch into adding dispenso/1.2.0 recipe

41aaa6b

AbrilRBS self-assigned this


Normalize conandata indentation

b0e7975

conan-center-bot added the Failed label

This comment has been minimized.

Sign in to view


Move to version 1.3.0

b2a9708

This comment has been minimized.

Sign in to view


Fix conandata

fc875ab

This comment has been minimized.

Sign in to view


Fix patches for 1.3.0

d77e120

This comment has been minimized.

Sign in to view

AbrilRBS added 3 commits

April 26, 2024 23:22


Set C++ if no cppstd is set to support apple-clang in Conan 1

8519c8f


Improve v1 check

30125a5


Better test package

1369f39

conan-center-bot removed the Failed label

This comment has been minimized.

Sign in to view

Contributor

github-actions bot commented Apr 26, 2024

Hooks produced the following warnings for commit 1369f39

dispenso/1.3.0@#9b8495def33c41cf746144b89c931b37

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdispenso.so' links to system library 'm' but it is not in cpp_info.system_libs.


Add missing m system lib in linux

c35e5d2

This comment has been minimized.

Sign in to view


Remove todo

e1b2ce7

AbrilRBS marked this pull request as ready for review

April 29, 2024 22:19

AbrilRBS mentioned this pull request

[Bug]: warn_unused_result compilation error in dispenso/priority.cpp for Linux facebookincubator/dispenso#27

Closed

1 task

This comment has been minimized.

Sign in to view

prince-chrismc mentioned this pull request

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

uilianries previously approved these changes

View reviewed changes

Member

uilianries left a comment

Looking good, I would suggest only dropping cmake_find_package and we are good to go.

recipes/dispenso/all/conanfile.py Outdated Show resolved Hide resolved

recipes/dispenso/all/patches/1.3.0-001-unvendorize-concurrentqueue.patch Outdated

Member

uilianries May 7, 2024

I would add a personal note to send a PR to the upstream, adding an option to consume as external library :)


Update recipes/dispenso/all/conanfile.py

33aa262

Co-authored-by: Uilian Ries <uilianries@gmail.com>

AbrilRBS dismissed uilianries’s stale review via

33aa262

May 7, 2024 08:22

uilianries approved these changes

View reviewed changes

Member

uilianries left a comment

LGTM

Collaborator

conan-center-bot commented May 7, 2024

Conan v1 pipeline ✔️

All green in build 8 (33aa262cf057abcccb472f8f030ca8b53580cd1f):

dispenso/1.3.0:
All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 8 (33aa262cf057abcccb472f8f030ca8b53580cd1f):

dispenso/1.3.0:
All packages built successfully! (All logs)

jwillikers approved these changes

View reviewed changes

uilianries assigned uilianries and unassigned uilianries

AbrilRBS assigned uilianries and unassigned AbrilRBS

conan-center-bot merged commit 99c3536 into conan-io:master

13 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment