-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pipewire: Add recipe #22991
base: master
Are you sure you want to change the base?
pipewire: Add recipe #22991
Conversation
This comment has been minimized.
This comment has been minimized.
0213c18
to
86e06ac
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
488a110
to
90cdca1
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
46fe823
to
a65f746
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Version 1.2.1 includes threads.h, introduced in glibc 2.28. The header doesn't exist in CCI.
This comment has been minimized.
This comment has been minimized.
if os.getenv("CONAN_CENTER_BUILD_SERVICE") is not None: | ||
self.options.with_xfixes = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A source-code comment explaining the purpose of this would be nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
recipes/pipewire/all/conanfile.py
Outdated
for dependency, _value in self.dependencies.direct_host.items(): | ||
if dependency.ref.name == "linux-headers-generic": | ||
for includedir in self.dependencies.direct_host[ | ||
"linux-headers-generic" | ||
].cpp_info.includedirs: | ||
tc.c_args.append(f"-I{includedir}") | ||
break |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the extra for loops really necessary?
for dependency, _value in self.dependencies.direct_host.items(): | |
if dependency.ref.name == "linux-headers-generic": | |
for includedir in self.dependencies.direct_host[ | |
"linux-headers-generic" | |
].cpp_info.includedirs: | |
tc.c_args.append(f"-I{includedir}") | |
break | |
for includedir in self.dependencies["linux-headers-generic"].cpp_info.includedirs: | |
tc.c_args.append(f"-I{includedir}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason, I think that I had trouble with this a while ago. Oh, it came back to me. I did it this way because otherwise, using a platform_requires
for linux-headers-generic
will cause this to fail.
Co-authored-by: Martin Valgur <martin.valgur@gmail.com>
recipes/pipewire/all/conanfile.py
Outdated
self.runenv_info.define( | ||
"PIPEWIRE_MODULE_DIR", | ||
os.path.join( | ||
self.package_folder, "lib", f"pipewire-{libpipewire_api_version}" | ||
), | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolute nitpicking, but could you set the column limit to 100 or 120 for black
, please?
The line wrapping is a bit excessive and only hurts readability, imo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reformatted with a longer line length with Ruff. It would be great to have formatting configured for the repository so no one has to think about this kind of thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If your IDE supports .editorconfig then it is configured
conan-center-index/.editorconfig
Line 12 in 2c3904f
max_line_length = 200 |
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 21 (
Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping Failure in build 21 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
PipeWire is a project that aims to greatly improve handling of audio and video under Linux.
Fixes #18533.
Requires the following for optional ffmpeg support to be enabled.
This support won't be enabled by default, so it shouldn't be required to merge this PR.
Fyi, the support for
ffmpeg
should never be enabled by default because it will cause circular dependencies sinceffmpeg
requiressdl
which now requirespipewire
.