Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

harfbuzz: Disable auto-features which pull in system dependencies #23011

Merged
merged 3 commits into from
Mar 16, 2024
Merged

harfbuzz: Disable auto-features which pull in system dependencies #23011

merged 3 commits into from
Mar 16, 2024

Conversation

jwillikers
Copy link
Contributor

@jwillikers jwillikers commented Mar 6, 2024 •
edited
Loading

Harfbuzz autodetects cairo and pulls it in, which breaks reproducibility. This also breaks cross compilation by pulling in dependencies on the build system. Disabling auto features in Meson stops this unexpected behavior from happening. See here

@jwillikers
harfbuzz: Disable auto-features which pull in system dependencies
323294b 
It autodetects cairo and pulls it in, which breaks reproducibility.
This also breaks cross compilation by pulling in dependencies on the build system.
@prince-chrismc prince-chrismc mentioned this pull request Mar 6, 2024
Open
@AbrilRBS AbrilRBS self-assigned this Mar 6, 2024
@conan-center-bot

This comment has been minimized.

Sign in to view
@AbrilRBS
Copy link
Member

Looks good to me :)

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 3 (91208f307b5d3be8fff8aa5c9ea49d3c3dfce777):

  • harfbuzz/8.3.0:
    All packages built successfully! (All logs)

  • harfbuzz/8.2.2:
    All packages built successfully! (All logs)

  • harfbuzz/8.2.1:
    All packages built successfully! (All logs)

  • harfbuzz/8.1.1:
    All packages built successfully! (All logs)

  • harfbuzz/7.3.0:
    All packages built successfully! (All logs)

  • harfbuzz/8.0.1:
    All packages built successfully! (All logs)

  • harfbuzz/6.0.0:
    All packages built successfully! (All logs)

  • harfbuzz/5.1.0:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 3 (91208f307b5d3be8fff8aa5c9ea49d3c3dfce777):

  • harfbuzz/8.3.0:
    All packages built successfully! (All logs)

  • harfbuzz/8.2.2:
    All packages built successfully! (All logs)

  • harfbuzz/8.2.1:
    All packages built successfully! (All logs)

  • harfbuzz/8.0.1:
    All packages built successfully! (All logs)

  • harfbuzz/8.1.1:
    All packages built successfully! (All logs)

  • harfbuzz/6.0.0:
    All packages built successfully! (All logs)

  • harfbuzz/7.3.0:
    All packages built successfully! (All logs)

  • harfbuzz/5.1.0:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 309abf8 into conan-io:master Mar 16, 2024
48 checks passed
@jwillikers jwillikers deleted the harfbuzz-disable-auto branch March 16, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericLemanissier ericLemanissier ericLemanissier approved these changes

@uilianries uilianries uilianries approved these changes

@AbrilRBS AbrilRBS AbrilRBS approved these changes

Assignees

@AbrilRBS AbrilRBS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jwillikers @conan-center-bot @AbrilRBS @ericLemanissier @uilianries