Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add yoga version 3.0.2 #23019

Merged
merged 6 commits into from
Mar 19, 2024
Merged

Add yoga version 3.0.2 #23019

merged 6 commits into from
Mar 19, 2024

Conversation

hedtke
Copy link
Contributor

@hedtke hedtke commented Mar 7, 2024

Specify library name and version: yoga/3.0.0

@prince-chrismc prince-chrismc mentioned this pull request Mar 7, 2024
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@hedtke
Copy link
Contributor Author

hedtke commented Mar 7, 2024

Failing build discussed in upstream: facebook/yoga#1590

@ericLemanissier ericLemanissier mentioned this pull request Mar 7, 2024
Closed
This was referenced Mar 8, 2024
Open
Closed
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@hedtke
Copy link
Contributor Author

hedtke commented Mar 11, 2024

Ready for review, we patch out the Werror setting in CMake

@hedtke hedtke marked this pull request as draft March 11, 2024 20:10
@hedtke
Copy link
Contributor Author

hedtke commented Mar 11, 2024

There will be a patch release I am waiting for, we wouldn't need a patch when we leave out v3.0.0: facebook/yoga#1590 (comment)

@conan-center-bot

This comment has been minimized.

Sign in to view
@hedtke hedtke changed the title Add yoga version 3.0.0 Add yoga version 3.0.2 Mar 13, 2024
@hedtke hedtke marked this pull request as ready for review March 13, 2024 07:55
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 7 (c9ed5e295b35d884aea4a947ef55731f38941b64):

  • yoga/2.0.0:
    All packages built successfully! (All logs)

  • yoga/2.0.1:
    All packages built successfully! (All logs)

  • yoga/3.0.2:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 7 (c9ed5e295b35d884aea4a947ef55731f38941b64):

  • yoga/2.0.1:
    All packages built successfully! (All logs)

  • yoga/2.0.0:
    All packages built successfully! (All logs)

  • yoga/3.0.2:
    All packages built successfully! (All logs)

@hedtke hedtke mentioned this pull request Mar 13, 2024
Closed
@AbrilRBS AbrilRBS self-assigned this Mar 19, 2024
AbrilRBS
AbrilRBS approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@conan-center-bot conan-center-bot merged commit d80f708 into conan-io:master Mar 19, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwillikers jwillikers jwillikers approved these changes

@AbrilRBS AbrilRBS AbrilRBS approved these changes

Assignees

@AbrilRBS AbrilRBS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hedtke @conan-center-bot @AbrilRBS @jwillikers