-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openvino: Add threading option supporting tbb and omp #23068
base: master
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
547a0a2
to
cc1a3f2
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Thanks! You will need to add I see that Somewhat blocked by #22353, though. |
@@ -166,7 +170,8 @@ def build_requirements(self): | |||
self.tool_requires("cmake/[>=3.18 <4]") | |||
|
|||
def requirements(self): | |||
self.requires("onetbb/2021.10.0") | |||
if self.options.threading == "tbb": | |||
self.requires("onetbb/2021.10.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self.requires("onetbb/2021.10.0") | |
# https://github.com/openvinotoolkit/openvino/blob/2024.0.0/src/core/include/openvino/core/parallel.hpp#L186-L190 | |
self.requires("onetbb/2021.10.0", transitive_headers=True, transitive_libs=True) |
TBB includes are being used in a public header, if I understand it correctly.
Co-authored-by: Martin Valgur <martin.valgur@gmail.com>
Conan v1 pipeline ❌Failure in build 4 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
"enable_pytorch_frontend": [True, False] | ||
"enable_pytorch_frontend": [True, False], | ||
# Threading | ||
"threading": ["tbb", "omp"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seq
is also available to disable the threading- can we enable
threading
since 2024.4 ? because before that version OpenMP support was not enough tested / supported.
Suppressed by #25698 |
Specify library name and version: openvino/*
Adds the option to set the threading cmake option to either tbb or omp.
Currently has an issue upon cmake config with projects using this option with openvino.