Updates libsndfile to use conan-provided libsndio #23150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
ghost
mentioned this pull request
danimtb
reviewed
Nov 22, 2024
recipes/libsndfile/all/conanfile.py
Outdated
| if self.options.get_safe("with_alsa"): | ||
| self.options["libsndio"].with_alsa = True |
There was a problem hiding this comment.
It seems that this option is defaulted to True in libsndio recipe, to it should be true by default in this recipe as well. Otherwise, there will be no prebuilt packages to libsndio that have with_alsa=False option and the CI will fail (it builds default options only and does not build missing binaries from dependencies).
I am taking a look and will commit some changes to make the logic work in this recipe by setting the with_alsa=True by default. Hope that makes sense. Thank you!
|
The latest changes work fine as well when the option is set to false: |
AbrilRBS
previously approved these changes
Nov 22, 2024
danimtb
approved these changes
Nov 22, 2024
AbrilRBS
approved these changes
Nov 22, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on and follows #23087, solving issue conan-io/conan#15240.