bump sdl_image dependencies #23218
Open
bump sdl_image dependencies #23218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This was referenced Mar 22, 2024
valgur
approved these changes
Mar 24, 2024
memsharded
reviewed
Apr 1, 2024
| @@ -96,17 +96,17 @@ def layout(self): | |||
|
|
|||
| def requirements(self): | |||
| # Headers are exposed https://github.com/conan-io/conan-center-index/pull/16167#issuecomment-1508347351 | |||
| self.requires("sdl/2.28.3", transitive_headers=True) | |||
| self.requires("sdl/2.28.5", transitive_headers=True) | |||
There was a problem hiding this comment.
Maybe it would be better if we could use the latest sdl on ConanCenter, which is the 2.30.1? So the latest of sdl_image doesn't conflict with the latest of sdl?
There was a problem hiding this comment.
Well, responding to myself, and checking other recipes in ConanCenter, the other recipes in ConanCenter depends on 2.28, so this cannot be done and would require some coordination, please be patience, this might take some time. We are trying to improve the CI to be able to do these changes more streamlined, but this is a big effort.
| if self.options.with_libwebp: | ||
| self.requires("libwebp/1.3.2") | ||
| if self.options.get_safe("with_avif"): | ||
| self.requires("libavif/1.0.1") | ||
| self.requires("libavif/1.0.4") |
|
🚦 Thank for your Bump dependencies PR. The build service will be triggered soon by a Conan team member. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.