Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

premake: add 5.0.0-beta2, unvendor deps, add support for cross-building #23223

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Mar 23, 2024

Although a pre-release, v5.0.0 is being actively used by the yojimbo recipe, for example, so it's worth an update, imo. The existing version did not support cross-building.

Also unvendored libcurl, mbedtls, libzip and zlib to ensure that the most up-to-date versions of these are used.

Applied all patches to the non-bootstrapped build system based on the original premake build files instead of the pre-generated Makefiles and vcxprojects. This avoids the need to patch 13 different build configs.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

@Croydon Croydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied all patches to the non-bootstrapped build system based on the original premake build files instead of the bootstrap Makefiles and vcxprojects, which keeps the recipe much simpler.

I don't get it. What does the mean?

Is the way to build Premake that you choose official supported on all configurations?

Although a pre-release, v5.0.0 is being actively used by the yojimbo recipe, for example, so it's worth an update, imo.

This is really no criteria for a project that gets actively developed but is so afraid of stable releases, that their last official stable release is from 2010... see e.g. premake/premake-core#178

So, in the case of Premake it is completely okay to have alpha and beta releases added.

@valgur
Copy link
Contributor Author

valgur commented Mar 23, 2024

@Croydon

I don't get it. What does the mean?

See https://github.com/premake/premake-core/blob/master/BUILD.txt#L27

The packaged source archives include build scripts for each different platform (Linux and macOS Makefiles, VS projects, etc) that have been "bootstrapped" from the premake5.lua Premake build script.

Since this PR rewrites the build scripts to rely on dependencies from Conan instead of the vendored versions, it's much more efficient to modify the input premake5.lua script instead of the generated build files. That's the only real reason for the change. The recipe becoming simpler is a nice bonus, too.

Is the way to build Premake that you choose official supported on all configurations?

Yes. It's identical to what the project itself does for the source archives.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@valgur valgur changed the title premake: add 5.0.0-beta2, unvendor deps, simplify premake: add 5.0.0-beta2, unvendor deps, add support for cross-building Mar 27, 2024
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 12 (6e4a4b2c1c21d281ba49650c3a99acc51536fe2d):

  • premake/5.0.0-beta2:
    All packages built successfully! (All logs)

  • premake/5.0.0-alpha15:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 12 (6e4a4b2c1c21d281ba49650c3a99acc51536fe2d):

  • premake/5.0.0-alpha15:
    All packages built successfully! (All logs)

  • premake/5.0.0-beta2:
    All packages built successfully! (All logs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants