-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opencv 4.x: re-enable quirc by default #23242
Conversation
I realize that always disabling WITH_QUIRC can be confusing for other maintainers, so I've pushed another commit where the mapping between with_quirc recipe option and WITH_QUIRC CMakeLists option introduced by #22136 is kept. But now manual injection of HAVE_QUIRC is not required anymore. Moreover I've explained the logic in a comment above removal of |
Conan v1 pipeline ✔️All green in build 2 (
Conan v2 pipeline ✔️
All green in build 2 ( |
Hooks produced the following warnings for commit ba1ab41opencv/4.8.1@#ca6633f031560c19dc47a34c76d5509a
opencv/4.1.2@#e8b349fc8c0724c2641579e41c2cc2a3
opencv/4.9.0@#fadd44c87e06cd62e207b1b7e580b293
opencv/4.5.3@#e6b887d4df943cb79a6c08988af4499a
opencv/4.5.5@#e3b96ce73d0a6a40d64b1e0e685604b9
|
* re-enable quirc by default for opencv < 4.9 * less confusing patches
* re-enable quirc by default for opencv < 4.9 * less confusing patches
Revert default value of
with_quirc
option.It has been changed by #22136, specifically by these commits: a9001e4 & b3c5e4e, but I don't see any reason for these modifications.
See also #22136 (comment) & #22136 (comment)
/cc @RubenRBS