-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
platformfolders: add new recipe for platformfolders #23270
Conversation
This comment has been minimized.
This comment has been minimized.
d30f3a6
to
cda198a
Compare
This comment has been minimized.
This comment has been minimized.
ac7fbac
to
0f3a5f0
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit c50e255platformfolders/4.2.0@#d7db8c26dde424953a17c8d483b9e038
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Sorry for the delay on getting this one merged, we appreciate your patience :)
Signed-off-by: Uilian Ries <uilianries@gmail.com>
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The upstream still does not support shared on Windows, which means, it will provoke failure in case using conan install .... -o *:shared=True
configuration. This configuration is used by the CI here, so in case any recipe consume platfromfolders, it will not generate shared library too. Instead, we can enforce to only provide static library and it should be used with shared too.
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 976f427platformfolders/4.2.0@#587d2e9a5e3256845166ea191de9b9e8
|
Conan v1 pipeline ✔️All green in build 18 (
Conan v2 pipeline ✔️
All green in build 18 (
|
Specify library name and version: platformfolders/4.2.0
The reason that the package_type is static-library is this library do not export any symbol when build shared library with msvc. The fixup pull request is here. The package_type could be change to library and adding shared option when this pr is merged.