Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

platformfolders: add new recipe for platformfolders #23270

Merged
merged 7 commits into from
May 20, 2024

Conversation

xyz1001
Copy link
Contributor

@xyz1001 xyz1001 commented Mar 26, 2024

Specify library name and version: platformfolders/4.2.0

The reason that the package_type is static-library is this library do not export any symbol when build shared library with msvc. The fixup pull request is here. The package_type could be change to library and adding shared option when this pr is merged.


@conan-center-bot

This comment has been minimized.

@xyz1001 xyz1001 force-pushed the master branch 2 times, most recently from d30f3a6 to cda198a Compare March 26, 2024 07:18
@conan-center-bot

This comment has been minimized.

@xyz1001 xyz1001 force-pushed the master branch 2 times, most recently from ac7fbac to 0f3a5f0 Compare March 26, 2024 10:35
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@uilianries
Copy link
Member

@xyz1001 Thank you for your PR. Please, consider the PR xyz1001#2 as review/fix.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Apr 2, 2024

Hooks produced the following warnings for commit c50e255
platformfolders/4.2.0@#d7db8c26dde424953a17c8d483b9e038
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libplatform_folders.so' links to system library 'm' but it is not in cpp_info.system_libs.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

danimtb
danimtb previously approved these changes May 9, 2024
AbrilRBS
AbrilRBS previously approved these changes May 9, 2024
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry for the delay on getting this one merged, we appreciate your patience :)

xyz1001 and others added 2 commits May 10, 2024 08:38
@conan-center-bot

This comment has been minimized.

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upstream still does not support shared on Windows, which means, it will provoke failure in case using conan install .... -o *:shared=True configuration. This configuration is used by the CI here, so in case any recipe consume platfromfolders, it will not generate shared library too. Instead, we can enforce to only provide static library and it should be used with shared too.

recipes/platformfolders/all/conanfile.py Show resolved Hide resolved
recipes/platformfolders/all/conanfile.py Outdated Show resolved Hide resolved
recipes/platformfolders/all/conanfile.py Outdated Show resolved Hide resolved
Co-authored-by: Uilian Ries <uilianries@gmail.com>
@AbrilRBS AbrilRBS dismissed stale reviews from danimtb and themself via 0dc398e May 10, 2024 19:10
AbrilRBS and others added 2 commits May 10, 2024 21:10
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

Hooks produced the following warnings for commit 976f427
platformfolders/4.2.0@#587d2e9a5e3256845166ea191de9b9e8
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libplatform_folders.so' links to system library 'm' but it is not in cpp_info.system_libs.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 18 (eb61504e1167d49ebb13400a17da263df3b03c74):

  • platformfolders/4.2.0:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 18 (eb61504e1167d49ebb13400a17da263df3b03c74):

  • platformfolders/4.2.0:
    All packages built successfully! (All logs)

@danimtb danimtb requested a review from uilianries May 20, 2024 13:47
@conan-center-bot conan-center-bot merged commit 07ce6e8 into conan-io:master May 20, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants