-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qt/6: Use libglvnd on FreeBSD and Linux #23279
Conversation
🤖 Beep Boop! This pull request is making changes to 'recipes/qt//'. 👋 @ericLemanissier @jwillikers @MartinDelille @paulharris you might be interested. 😉 |
I detected other pull requests that are modifying qt/6.x.x recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
The libglvnd package provides the necessary opengl/system and egl/system dependencies. The libglvnd package is a proper, non-system Conan package. Remove unnecessary check for wayland being enabled in xkbcommon. The Wayland option in xkbcommon only effects building an executable tool.
2c232b2
to
02b52a6
Compare
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 02b52a6qt/6.6.2@#ce6d32f9e4bff1ead94f8030a3a5cd9f
qt/6.6.1@#fff0af0cff4db2e18a02875eaeef6cbf
qt/6.6.0@#a5b37d33ca74172cd2c986ec97243fff
qt/6.5.3@#5902b4ee5ee374c0ab6dc32f5531b1f6
qt/6.4.2@#00548d57924207e65ddbba100ee9f79a
qt/6.3.2@#d9766f056df2d6caf1c38964e778dedd
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
something is not coherent between requirements(self)
and package_info(self)
: egl/system
is required but never referenced as requirement of a component.
It'd be better if all the requirements and components where defined in a common place (function or structure) which would then be exploited by requires(self)
and package_info(self)
. I wish I had done this from the start, the work is much bigger now :/
I think I've fixed the missing |
Conan v1 pipeline ✔️All green in build 3 (
Conan v2 pipeline ✔️
All green in build 3 (
|
Hooks produced the following warnings for commit f431abfqt/6.6.2@#9187bd2093309dbf5a95635a0ebd092d
qt/6.6.1@#d5f812858269c15598c1c2aa952c9074
qt/6.5.3@#951d24ec715efa3a60e128280ced3dfe
qt/6.3.2@#7ffa894640f2f9fa8795402f9e836e4c
qt/6.6.0@#9ff7e9d339bf97c578112839520f1cd3
qt/6.4.2@#3e8a7faf08755c2c6d5c883ba477b0af
|
Closing pending discussion at #23649 Also perhaps relevant to Qt only: back in the day, the generated |
The
libglvnd
package provides the necessaryopengl/system
andegl/system
dependencies on FreeBSD and Linux. The libglvnd package is a proper, non-system Conan package. This PR also removes an unnecessary check for wayland being enabled in xkbcommon. The Wayland option in xkbcommon only effects building an executable tool.