Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yes, yes, this caused a world of pain due to the default
shared=True
andConanInvalidConfiguration
thrown for static 2021.06 and later versions for a good measure (#20897).Nevertheless, the static linkage is merely discouraged and left as a responsibility of the user to take care of any unforeseen issues (uxlfoundation/oneTBB#646 (comment)).
I'm in the process of porting KISS-ICP over to Conan and the project has been using the latest version of OneTBB with static linkage without any issues, despite being one of the most popular lidar mapping libraries in recent years. So I would love to see the option returned, if possible.
To avoid the issues described in #20897, I set the default value of
shared
toFalse
. Which is not ideal, but there's no alternative currently due to C3I limitations.