Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onetbb: restore shared option #23296

Closed
wants to merge 1 commit into from
Closed

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Mar 27, 2024

Yes, yes, this caused a world of pain due to the default shared=True and ConanInvalidConfiguration thrown for static 2021.06 and later versions for a good measure (#20897).

Nevertheless, the static linkage is merely discouraged and left as a responsibility of the user to take care of any unforeseen issues (uxlfoundation/oneTBB#646 (comment)).

I'm in the process of porting KISS-ICP over to Conan and the project has been using the latest version of OneTBB with static linkage without any issues, despite being one of the most popular lidar mapping libraries in recent years. So I would love to see the option returned, if possible.

To avoid the issues described in #20897, I set the default value of shared to False. Which is not ideal, but there's no alternative currently due to C3I limitations.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Failure in build 1 (5e0f9ea448934aa4cd986f90439ad50a68f1a1fd):

  • onetbb/2021.10.0:
    CI failed to create some packages (All logs)

    Logs for packageID df970d8bab8310c974c30eeb573c490728fc4334:
    [settings]
    arch=x86_64
    build_type=Debug
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=11
    os=Linux
    [options]
    onetbb:shared=False
    
    [...]
    -- Found: /home/conan/workspace/prod-v1/bsr/11242/dbccd/.conan/data/hwloc/2.9.3/_/_/package/b1f16af781adfb3a6363e038c2fe7696d01bf665/lib/libhwloc.so
    -- Configuring done
    -- Generating done
    -- Build files have been written to: /home/conan/workspace/prod-v1/bsr/cci-8f694988/recipes/onetbb/all/test_v1_package/build/3663418fd77b079ebaa005b3bce05a8e00556d80
    
    ----Running------
    > cmake --build '/home/conan/workspace/prod-v1/bsr/cci-8f694988/recipes/onetbb/all/test_v1_package/build/3663418fd77b079ebaa005b3bce05a8e00556d80' '--' '-j3'
    -----------------
    Scanning dependencies of target test_package
    [ 50%] Building CXX object test_package/CMakeFiles/test_package.dir/test_package.cpp.o
    [100%] Linking CXX executable ../bin/test_package
    [100%] Built target test_package
    onetbb/2021.10.0 (test package): Running test()
    
    ----Running------
    > bin/test_package
    -----------------
    Fib 6=CMake Warning:
      Manually-specified variables were not used by the project:
    
        CMAKE_EXPORT_NO_PACKAGE_REGISTRY
        CMAKE_INSTALL_BINDIR
        CMAKE_INSTALL_DATAROOTDIR
        CMAKE_INSTALL_INCLUDEDIR
        CMAKE_INSTALL_LIBDIR
        CMAKE_INSTALL_LIBEXECDIR
        CMAKE_INSTALL_OLDINCLUDEDIR
        CMAKE_INSTALL_SBINDIR
    
    
    Assertion node(val).my_prev_node == &node(val) && node(val).my_next_node == &node(val) failed (located in the push_front function, line in file: 134)
    Detailed description: Object with intrusive list node can be part of only one intrusive list simultaneously
    Aborted
    onetbb/2021.10.0: WARN: oneTBB strongly discourages usage of static linkage
    onetbb/2021.10.0 (test package): WARN: 
         ************************************************
         The 'cmake' generator is deprecated.
         Please update your code and remove it.
         *************************************************
    
    onetbb/2021.10.0 (test package): WARN: 
         ************************************************
         The 'cmake_find_package_multi' generator is deprecated.
         Please update your code and remove it.
         *************************************************
    
    onetbb/2021.10.0 (test package): WARN: **** The 'from conans import CMake' helper is deprecated. Please update your code and remove it. ****
    ERROR: onetbb/2021.10.0 (test package): Error in test() method, line 17
    	self.run(bin_path, run_environment=True)
    	ConanException: Error 134 while executing bin/test_package
    
  • onetbb/2021.9.0:
    Didn't run or was cancelled before finishing

  • onetbb/2021.6.0:
    Didn't run or was cancelled before finishing

  • onetbb/2021.8.0:
    Didn't run or was cancelled before finishing

  • onetbb/2021.7.0:
    Didn't run or was cancelled before finishing

  • onetbb/2021.3.0:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@valgur valgur closed this Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants