Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NCBI C++ Toolkit #23392

Open
wants to merge 40 commits into
base: master
Choose a base branch
from
Open

NCBI C++ Toolkit #23392

wants to merge 40 commits into from

Conversation

gouriano
Copy link
Contributor

@gouriano gouriano commented Apr 5, 2024

ncbi-cxx-toolkit-public/28.0.0

The Toolkit is a public-domain collection of portable libraries, consisting of a cross-platform application framework and a set of utilities and supporting classes to work with biological data. It serves as a foundation of multiple projects at NCBI.
Please add v28.0.0


@conan-center-bot

This comment has been minimized.

@conan-center-bot conan-center-bot removed Failed Missing dependencies Build failed due missing dependencies in Conan Center labels Apr 9, 2024
@conan-center-bot

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Apr 9, 2024

Hooks produced the following warnings for commit fecf6a0
ncbi-cxx-toolkit-public/28.0.0@#ca79159c0e0077eae252af3a8c2591be
post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] cpp_info.components["core"].build_modules is not a dictionary
post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] cpp_info.components["core"].build_modules is not a dictionary

@gouriano
Copy link
Contributor Author

"Some checks haven’t completed yet"?
Could you please let us know when can we expect them to be completed? Is anything missing on our side?
Also, we would appreciate if you let us know when could we expect this to be reviewed.
Thanks

@conan-center-bot

This comment has been minimized.

@gouriano
Copy link
Contributor Author

I see there are problems with Linux, GCC. In my opinion, the problem is with grpc/protobuf.
If I build it with "-o /:shared=True -o protobuf/:shared=False -o grpc/:shared=False", everything is just fine.
Or, do I miss something?

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

Hooks produced the following warnings for commit 15284ba
ncbi-cxx-toolkit-public/28.0.0@#0e89e343fc20356f6dfdef01f1cd5e3c
post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] cpp_info.components["core"].build_modules is not a dictionary
post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] cpp_info.components["core"].build_modules is not a dictionary

self.cpp_info.components["core"].frameworks = ["ApplicationServices"]
self.cpp_info.components["core"].builddirs.append("res")
build_modules = [self._module_file_rel_path]
self.cpp_info.components["core"].build_modules = build_modules
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
self.cpp_info.components["core"].build_modules = build_modules
self.cpp_info.components["core"].build_modules["cmake_find_package"] = build_modules
self.cpp_info.components["core"].build_modules["cmake_find_package_multi"] = build_modules

@conan-center-bot

This comment has been minimized.

@valgur
Copy link
Contributor

valgur commented Sep 23, 2024

This one has been green for a while, but there's no assigned reviewer. Tagging you just in case, @uilianries.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 6 (e146bef4d51decd4b0c92c68d6e77449fd9edda9):

  • ncbi-cxx-toolkit-public/28.0.0:
    Built 16 packages out of 22 (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 6 (e146bef4d51decd4b0c92c68d6e77449fd9edda9):

  • ncbi-cxx-toolkit-public/28.0.0:
    Built 6 packages out of 10 (All logs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants