Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openldap] fix package #23520

Closed
wants to merge 2 commits into from
Closed

[openldap] fix package #23520

wants to merge 2 commits into from

Conversation

SSE4
Copy link
Contributor

@SSE4 SSE4 commented Apr 14, 2024

Specify library name and version: openldap/2.6.7

this PR fixes the following error message whenever attempt to require openldap package:

*********************************************************
Recipe 'openldap/2.6.1' seems broken.
It is possible that this recipe is not Conan 2.0 ready
If the recipe comes from ConanCenter, report it at https://github.com/conan-io/conan-center-index/issues
If it is your recipe, check if it is updated to 2.0
*********************************************************

ERROR: Package 'openldap/2.6.1' not resolved: openldap/2.6.1: Cannot load recipe.
Error loading conanfile at '/home/conan/.conan2/p/openlf39aff6d5434b/e/conanfile.py': Unable to load conanfile in /home/conan/.conan2/p/openlf39aff6d5434b/e/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/.conan2/p/openlf39aff6d5434b/e/conanfile.py", line 2, in <module>
    from conans import ConanFile, AutoToolsBuildEnvironment, tools
ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

@conan-center-bot

This comment has been minimized.

@ghost
Copy link

ghost commented Apr 14, 2024

I detected other pull requests that are modifying openldap/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot

This comment has been minimized.

@AbrilRBS
Copy link
Member

Hi! Have you checked if #18800 also fixes your issue?

@SSE4
Copy link
Contributor Author

SSE4 commented Apr 16, 2024

Hi! Have you checked if #18800 also fixes your issue?

no, I didn't. the PR your linked is related to the conan 2 migration. my goal is only to fix specific error message.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@valgur
Copy link
Contributor

valgur commented Apr 17, 2024

Hi! Have you checked if #18800 also fixes your issue?

no, I didn't. the PR your linked is related to the conan 2 migration. my goal is only to fix specific error message.

Uhm... the specific error message and your fixes are entirely about Conan v2 migration, though. 😄
Not that I'm complaining. Thank you for taking a shot at this.

@SSE4
Copy link
Contributor Author

SSE4 commented Apr 17, 2024

the specific error message and your fixes are entirely about Conan v2 migration, though. 😄

I don't see the word "migration" in the error message 🤔

@SSE4 SSE4 force-pushed the openldap/fix branch 2 times, most recently from 31bbb93 to 8f19c2e Compare April 17, 2024 07:26
@valgur
Copy link
Contributor

valgur commented Apr 17, 2024

I'm not sure if you're being serious or not, but anyway: https://docs.conan.io/1/migrating_to_2.0/recipes.html#python-import-statements

@conan-center-bot

This comment has been minimized.


def requirements(self):
self.requires("openssl/1.1.1q")
self.requires("openssl/3.2.1")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
self.requires("openssl/3.2.1")
self.requires("openssl/[>=1.1 <4]")

In order to prevent not only version conflicts, but also downloading the latest version available, please, consider version range.

https://github.com/conan-io/conan-center-index/blob/master/docs/adding_packages/dependencies.md#version-ranges

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 16 (e3979deeca4896cca57b7993f61a679056bddc7d):

  • openldap/2.6.7:
    All packages built successfully! (All logs)

  • openldap/2.6.1:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 15 (e3979deeca4896cca57b7993f61a679056bddc7d):

  • openldap/2.6.7:
    All packages built successfully! (All logs)

  • openldap/2.6.1:
    All packages built successfully! (All logs)

@uilianries
Copy link
Member

Closing this PR as it's superseded by #18800, including new release 2.6.7.

Thank you for your pull request, please, update your local copy of openldap.

Feel free to re-open it in case you find a change in this PR that should be added to the recipe too.

@uilianries uilianries closed this Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants