tidwall-neco: add recipe #23521
Merged
tidwall-neco: add recipe #23521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
AbrilRBS
reviewed
Apr 15, 2024
|
@RubenRBS |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
AbrilRBS
reviewed
May 14, 2024
| cmake_layout(self, src_folder="src") | ||
|
|
||
| def validate(self): | ||
| if is_msvc(self): |
There was a problem hiding this comment.
I think this is no longer the case in the new version? Could you try to disable this check, see if this works now?
There was a problem hiding this comment.
@RubenRBS
Removed.
Let's see the result.
There was a problem hiding this comment.
@RubenRBS
There is still compilation errors on MSVC.
It is caused by lack of stdatomic.h which is introduced in C11.
Because I have no idea to workaround it, I'm going to drop support for msvc.
C:\J\workspace\prod-v1\bsr@4\43174\abeda\.conan\data\tidwall-neco\0.3.2\_\_\build\d057732059ea44a47760900cb5e4855d2bea8714\src\neco.c(163,1): fatal error C1083: Cannot open include file: 'stdatomic.h': No such file or directory [C:\J\workspace\prod-v1\bsr@4\43174\abeda\.conan\data\tidwall-neco\0.3.2\_\_\build\d057732059ea44a47760900cb5e4855d2bea8714\build\neco.vcxproj]
Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 13 (
Conan v2 pipeline ✔️
All green in build 13 (
|
danimtb
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: tidwall-neco/*
Because neco includes
unistd.h, neco doesn't support MSVC.https://github.com/tidwall/neco/blob/v0.2.0/neco.c#L2202