New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduct-cpp: add recipe #23524

Open

toge wants to merge 20 commits into conan-io:master from toge:reduct-cpp-add-recipe

Contributor

toge commented Apr 14, 2024 •

edited

Loading

Specify library name and version: reduct-cpp/*

Apple-clang doesn't support reduct-cpp due to operator<=> support.
https://developer.apple.com/xcode/cpp/#c++20

I've read the contributing guidelines.
I've used a recent Conan client version close to the currently deployed.
I've tried at least one configuration locally with the conan-center hook activated.


          reduct-cpp: add recipe

de0d682

conan-center-bot added the Service Under Maintenance label

This comment has been minimized.

Sign in to view

prince-chrismc mentioned this pull request

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

AbrilRBS self-assigned this

AbrilRBS reviewed

View reviewed changes

Member

AbrilRBS left a comment

Hi! Thanks a lot, only a minor change, otherwise this looks super good :)

recipes/reduct-cpp/all/patches/1.9.0-0001-use-cci.patch Outdated Show resolved Hide resolved


          remove CMAKE_CXX_STANDARD

dc863ed

This comment has been minimized.

Sign in to view


          Merge branch 'master' into reduct-cpp-add-recipe

2dcfab5

conan-center-bot added Failed and removed Service Under Maintenance labels

This comment has been minimized.

Sign in to view


          require cmake

c859f27

This comment has been minimized.

Sign in to view

AbrilRBS reviewed

View reviewed changes

recipes/reduct-cpp/all/test_package/test_package.cpp Show resolved Hide resolved


          don't use network layer

8d46d34

This comment has been minimized.

Sign in to view


          revert to enable C++20

bfd3c83

This comment has been minimized.

Sign in to view


          drop support apple-clang

119fe5b

This comment has been minimized.

Sign in to view


          drop support clang < 14

b91578c

This comment has been minimized.

Sign in to view


          fix return type of spaceship operator

8da1485

This comment has been minimized.

Sign in to view


          fix lots of operator<=>

05234eb

This comment has been minimized.

Sign in to view


          use std::chrono::parse instead of date::parse

d903356

This comment has been minimized.

Sign in to view

atimin commented May 11, 2024

Hi @toge , the creator of the library here. I really appropriate your effort to integrate reduct-cpp into the conan infrastructure. If you need any support from my side, feel free to ask.


          relax fmtlib not to be "header-only"

This comment has been minimized.

Sign in to view


          simplify patch files

0b8011a

Contributor Author

toge commented May 11, 2024 •

edited

Loading

@atimin
Thank you for follow this PR!
I'm trying to pass all CI environments include Windows.
After it has been solved, I will create several PR to upstream which solve portability issues.

conan-center-bot removed the Failed label

This comment has been minimized.

Sign in to view


          update 1.10.0

08a2b8f

conan-center-bot added the Failed label

This comment has been minimized.

Sign in to view

ErniGH mentioned this pull request

Prioritization of new recipe PRs #24327

Open

toge added 2 commits

June 15, 2024 00:32


          include compare header

8723b31


          update cpp-httplib

871bb69

This comment has been minimized.

Sign in to view


          update 1.11.0

f7e5ac3

This comment has been minimized.

Sign in to view


          update 1.12.0

af66d7e

This comment was marked as outdated.

Sign in to view

Member

AbrilRBS commented Oct 5, 2024

Let me know if you need help getting msvc support sorted, but this might be a nice case for validating out such configuration if the errors persis :)


          Trigger build for PR-23524

e901999

Signed-off-by: Uilian Ries <uilianries@gmail.com>

uilianries reviewed

View reviewed changes

Member

uilianries left a comment

Thank you for your PR! 😄

recipes/reduct-cpp/all/conanfile.py Outdated Show resolved Hide resolved

recipes/reduct-cpp/all/patches/1.12.0-0001-use-cci.patch

+               set(CMAKE_LIBRARY_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/lib)
+              -include(cmake/InstallDependencies.cmake)
+              +find_package(fmt REQUIRED CONFIG)

Member

uilianries Nov 5, 2024

What situation! We need to patch it in order to not use Conan!

https://github.com/reductstore/reduct-cpp/blob/main/cmake/InstallDependencies.cmake#L12

recipes/reduct-cpp/all/patches/1.12.0-0004-include-compare.patch Outdated

Member

uilianries Nov 5, 2024

This patch could be sent to the upstream.


          require date only with_std_chrono is ON

1a2bb4e

Co-authored-by: Uilian Ries <uilianries@gmail.com>

Member

AbrilRBS commented Nov 7, 2024

Seems like this has issues compiling for Windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels