Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coin-buildtools: new recipe #23530

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Apr 15, 2024

Packages Autotools M4 files required for running autoreconf on the COIN-OR libraries on CCI. https://github.com/coin-or-tools/BuildTools

The COIN-OR libraries have been struggling with cross-building support on macOS and shared builds on MSVC due to the included configure scripts being generated with a fairly old Autoconf version. This will hopefully resolve these issues.

It also adds newer versions of the Autotools toolchain packages as transitive build-time requirements (but as self.requires() due to Conan v1 limitations) to ensure that up-to-date versions are being used.

@conan-center-bot

This comment has been minimized.

@valgur valgur force-pushed the new/coin-buildtools branch from f0d6a39 to bca8fc2 Compare April 15, 2024 11:22
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 5 (a710c3968b3c78bad35703f472a6915c8a2b123b):

  • coin-buildtools/0.8.11:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 5 (a710c3968b3c78bad35703f472a6915c8a2b123b):

  • coin-buildtools/0.8.11:
    All packages built successfully! (All logs)

@franramirez688 franramirez688 self-assigned this Jul 3, 2024
@EstebanDugueperoux2
Copy link
Contributor

Hi @uilianries @AbrilRBS @jcar87, @franramirez688 , I'm interested by this PR and all coin retaled ones.
Do you know when this could be reviewed?
Regards.

import os

from conan import ConanFile
from conan.tools.files import apply_conandata_patches, copy, export_conandata_patches, get, rename, mkdir, download
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
from conan.tools.files import apply_conandata_patches, copy, export_conandata_patches, get, rename, mkdir, download
from conan.tools.files import apply_conandata_patches, copy, export_conandata_patches, get, rename, download

To remove an unused import.

@valgur valgur force-pushed the new/coin-buildtools branch from 876fd90 to 676d4cf Compare November 13, 2024 06:45
@oleurodecision
Copy link
Contributor

Awaiting the coin stuff to start the transition to conan 2 (our recipes have already been updated to make the change a piece of cake)

Is there a way to help on the subject ? (not enough confident nor competent to review conan 2 recipes alas, but I'm currently testing our codebase against these new recipes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants