-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libsodium: add emscripten support to the libsodium recipe #23578
base: master
Are you sure you want to change the base?
libsodium: add emscripten support to the libsodium recipe #23578
Conversation
🤖 Beep Boop! This pull request is making changes to 'recipes/libsodium//'. 👋 @Hopobcn @paulharris you might be interested. 😉 |
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
de1b15a
to
787bd4f
Compare
This comment has been minimized.
This comment has been minimized.
…to-the-libsodium-recipe
Conan v1 pipeline ❌Failure in build 8 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. Conan v2 pipeline ✔️
All green in build 8 ( |
libsodium/1.0.19
The
--disable-ssp
option was missing which lead to linking errors due to the missing stack check functions in emscripten.Also, the libsodium-provided
script results in running:
so I've added the missing minimal/pthreads/asm/ssp options to the recipe to mimic the standard emscripten build options