-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[config] Re-order Mac M1 configuration #23594
Conversation
Signed-off-by: Uilian Ries <uilianries@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
under review
having taken the decision to simplify the test_packages, I'm not sure this is worth the effort. The test_packages should have never reached the level of complexity that some have reached. Guaranteeing a build order "would" fix the issue of test_packages failing when they require two package IDs of the same reference (that are built as part of the same PR), but it has a downside that it serialises what can otherwise be parallel. Out of 1743 test_packages in the repository, only the following have a dual requirement against the tested reference:
that's 18, in addition to I think we should refocus our efforts in ensuring that the very valid PRs against protobuf and the likes that are impacted by the issues can be swiftly merged, while in the background we continue our efforts to bring the test packages back in line with the original intention of the test packages. If this PR doesn't really guarantee that the test_packages will succeed due to race conditions, I wouldn't bother too much. |
@jcar87 OTOH this change has no adverse effect, and allows easy progress on all the recipes you listed |
All the recipes I've listed will have their test package refactored accordingly, should this become a problem (I think Qt is more complex and we will explore an alternative) |
I guess we don't use the same ruler to measure the height of low hanging fruits |
Closing as not planned. |
After further testing, this did not mitigate the issue. |
This change puts Mac M1 to be listed first when building packages in ConanCenterIndexCI. It does not guarantee the result as builds are execute in parallel, so a test package could ask for package that's not available yet.
Besides this change, Conan team will check for internal options/fix in C3I Jenkins code.
Related to #23558