Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xkbcommon: add components #2361

Merged
merged 5 commits into from
Aug 11, 2020
Merged

xkbcommon: add components #2361

merged 5 commits into from
Aug 11, 2020

Conversation

ericLemanissier
Copy link
Contributor

Specify library name and version: xkbcommon/*

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot
Copy link
Collaborator

All green in build 1 (6901997234a6c6c99ffc30e420d752344b845340)! 😊

@uilianries
Copy link
Member

@ericLemanissier It would be nice if you exercise the components in test_package/CMakeLists.txt, like adding find_package(xkbcommon REQUIRED); target_link_libraries(app xkbcommon::xkbcommon)

@conan-center-bot
Copy link
Collaborator

Some configurations of 'xkbcommon/0.10.0' failed in build 2 (c2652403161c819ba50812cebe36259a16be1d75):

  • Linux x86_64, Release, gcc 5, libstdc++ . Options: xkbcommon:shared-True
    • Hooks errors detected:
      • [HOOK - conan-center.py] post_package_info(): ERROR: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] The *.cmake files have to be placed in a folder declared as cpp_info.builddirs. Currently folders declared: [''] (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H019)
      • [HOOK - conan-center.py] post_package_info(): ERROR: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] Found files:
    • Log download
    • Log error Download
    • Profile
  • Access to all the logs

@ericLemanissier
Copy link
Contributor Author

the pkg-config test fails because CCI is running conan 1.27 which does not have conan-io/conan#7413
It will also fail with 1.28.0 because of conan-io/conan#7474. it should pass on 1.28.1

@SSE4 SSE4 added the infrastructure Waiting on tools or services belonging to the infra label Aug 3, 2020
@conan-center-bot
Copy link
Collaborator

Some configurations of 'xkbcommon/0.10.0' failed in build 3 (608f68a49083e15d89fc84156d7ba0d866c0222b):

  • Linux x86_64, Release, gcc 5, libstdc++ . Options: xkbcommon:shared-True
    • Hooks errors detected:
      • [HOOK - conan-center.py] post_package_info(): ERROR: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] The *.cmake files have to be placed in a folder declared as cpp_info.builddirs. Currently folders declared: [''] (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H019)
      • [HOOK - conan-center.py] post_package_info(): ERROR: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] Found files:
    • Log download
    • Log error Download
    • Profile
  • Access to all the logs

@conan-center-bot
Copy link
Collaborator

All green in build 4 (bc0b86190f7021a323b0eb64d804fe923ad9fe47)! 😊

@ericLemanissier
Copy link
Contributor Author

I reverted the components pkg-config test, so that it passes on conan 1.27, and can be merged without waiting conan 1.28.1 to be deployed on CCI

@uilianries uilianries removed the infrastructure Waiting on tools or services belonging to the infra label Aug 7, 2020
uilianries
uilianries previously approved these changes Aug 7, 2020
@uilianries uilianries requested review from jgsogo and SSE4 August 7, 2020 12:58
SSE4
SSE4 previously approved these changes Aug 9, 2020
recipes/xkbcommon/all/conanfile.py Outdated Show resolved Hide resolved
recipes/xkbcommon/all/test_package/conanfile.py Outdated Show resolved Hide resolved
@ericLemanissier ericLemanissier dismissed stale reviews from SSE4 and uilianries via 8a2e8cb August 10, 2020 09:01
@conan-center-bot
Copy link
Collaborator

All green in build 5 (8a2e8cba69c65b7fe71f0e335b5ce2ef28f248a0)! 😊

@SSE4 SSE4 merged commit fb54cdf into conan-io:master Aug 11, 2020
@SSE4 SSE4 deleted the xkbcommon branch August 11, 2020 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants