-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
botan: avoid configure.py failure when prefix path contains space #23632
botan: avoid configure.py failure when prefix path contains space #23632
Conversation
pichi-router
commented
Apr 18, 2024
- avoid configure.py failure when prefix path contains space
- avoid the exception raised by platform.libc_ver() when python was installed by Windows Store
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for taking the time to both report the issue AND create the PR, we really appreciate it
I have one minor suggestion, otherwise looks good!
(Also, when reporting bugs like this, it's great if alongside the "failing" compilation logs, you could also provide succesful compilations so that in the future we can refer back to those should we ever need to trace this issue back :) )
@@ -516,6 +516,8 @@ def _is_glibc_older_than_2_25_on_linux(self): | |||
# https://github.com/conan-io/conan-center-index/pull/18079#issuecomment-1919206949 | |||
# https://github.com/conan-io/conan-center-index/pull/18079#issuecomment-1919486839 | |||
|
|||
if self.settings.os != 'Linux': | |||
return False | |||
libver = platform.libc_ver() | |||
return ( | |||
self.settings.os == 'Linux' and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This check could now be deleted :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess so. But I'd prefer to proceed cautiously due to my limited knowledge on this subject. It's better to have it removed by a more experienced developer.
I hope the information above could be helpful. |
67070ab
to
f5aa45b
Compare
My previous email address is unavailable any more. I'm gonna re-submit the commit with a correct email. |
This comment has been minimized.
This comment has been minimized.
- avoid configure.py failure when prefix path contains space - avoid the exception raised by platform.libc_ver() when python was installed by Windows Store
This comment has been minimized.
This comment has been minimized.
This build was successful but the status check was not reported back to GitHub - will be updated shortly |
Conan v1 pipeline ✔️All green in build 4 (
Conan v2 pipeline ✔️
All green in build 2 (
|