Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

botan: avoid configure.py failure when prefix path contains space #23632

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

pichi-router
Copy link
Contributor

  • avoid configure.py failure when prefix path contains space
  • avoid the exception raised by platform.libc_ver() when python was installed by Windows Store

@conan-center-bot

This comment has been minimized.

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for taking the time to both report the issue AND create the PR, we really appreciate it

I have one minor suggestion, otherwise looks good!

(Also, when reporting bugs like this, it's great if alongside the "failing" compilation logs, you could also provide succesful compilations so that in the future we can refer back to those should we ever need to trace this issue back :) )

@@ -516,6 +516,8 @@ def _is_glibc_older_than_2_25_on_linux(self):
# https://github.com/conan-io/conan-center-index/pull/18079#issuecomment-1919206949
# https://github.com/conan-io/conan-center-index/pull/18079#issuecomment-1919486839

if self.settings.os != 'Linux':
return False
libver = platform.libc_ver()
return (
self.settings.os == 'Linux' and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check could now be deleted :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess so. But I'd prefer to proceed cautiously due to my limited knowledge on this subject. It's better to have it removed by a more experienced developer.

@AbrilRBS AbrilRBS self-assigned this Apr 20, 2024
@pichi-router
Copy link
Contributor Author

Thanks a lot for taking the time to both report the issue AND create the PR, we really appreciate it

I have one minor suggestion, otherwise looks good!

(Also, when reporting bugs like this, it's great if alongside the "failing" compilation logs, you could also provide succesful compilations so that in the future we can refer back to those should we ever need to trace this issue back :) )

  1. _is_glibc_older_than_2_25_on_linux complained an exception when the Python bundle was downloaded from Windows Store. The python.exe does exist at the exact location but libc_ver will still encounter errno 22.
PS C:\Users\Very Smart PC\project> conan install -b missing -s build_type=Debug .

======== Input profiles ========
Profile host:
[settings]
arch=x86_64
build_type=Debug
compiler=msvc
compiler.cppstd=14
compiler.runtime=dynamic   
compiler.runtime_type=Debug
compiler.version=193       
os=Windows
botan/*:compiler.cppstd=20 

Profile build:
[settings]
arch=x86_64
build_type=Debug
compiler=msvc
compiler.cppstd=14
compiler.runtime=dynamic   
compiler.runtime_type=Debug
compiler.version=193       
os=Windows
botan/*:compiler.cppstd=20 


======== Computing dependency graph ========
botan/3.4.0: Not found in local cache, looking in remotes...
botan/3.4.0: Checking remote: conancenter
botan/3.4.0: Downloaded recipe revision 3a6670dd6800e6586f8bf616a0e787dd
Graph root
    conanfile.txt: C:\Users\Very Smart PC\project\conanfile.txt
Requirements
    botan/3.4.0#3a6670dd6800e6586f8bf616a0e787dd - Downloaded (conancenter)
Resolved version ranges
    botan/[>=3.0.0]: botan/3.4.0

======== Computing necessary packages ========
botan/3.4.0: Checking 1 compatible configurations
botan/3.4.0: Compatible configurations not found in cache, checking servers
botan/3.4.0: 'd4cc82bcf7e95967bec87ec25b73e6607ac01cb4': compiler.cppstd=23
Requirements
    botan/3.4.0#3a6670dd6800e6586f8bf616a0e787dd:ff8fca64e2d4cc62769a2e60abab7543b6fc9101 - Build

======== Installing packages ========
botan/3.4.0: Sources downloaded from 'conancenter'
botan/3.4.0: Calling source() in C:\Users\Very Smart PC\.conan2\p\botanc1abc1c2efa18\s\src
botan/3.4.0: Downloading 12.1MB 3.4.0.tar.gz

-------- Installing package botan/3.4.0 (1 of 1) --------
botan/3.4.0: Building from source
botan/3.4.0: Package botan/3.4.0:ff8fca64e2d4cc62769a2e60abab7543b6fc9101
botan/3.4.0: Copying sources to build folder
botan/3.4.0: Building your package in C:\Users\Very Smart PC\.conan2\p\b\botan5f7df12d89006\b
botan/3.4.0: Calling generate()
botan/3.4.0: Generators folder: C:\Users\Very Smart PC\.conan2\p\b\botan5f7df12d89006\b\build-debug\conanbotan/3.4.0: Generating aggregated env files
botan/3.4.0: Generated aggregated env files: ['conanbuild.bat', 'conanrun.bat']
botan/3.4.0: Calling build()
botan/3.4.0: apply_conandata_patches(): No patches defined in conandata
botan/3.4.0: ERROR: 
Package 'ff8fca64e2d4cc62769a2e60abab7543b6fc9101' build failed
botan/3.4.0: WARN: Build folder C:\Users\Very Smart PC\.conan2\p\b\botan5f7df12d89006\b\build-debug
ERROR: botan/3.4.0: Error in build() method, line 248
        self.run(self._configure_cmd)
while calling '_configure_cmd', line 437
        if self._is_glibc_older_than_2_25_on_linux and Version(self.version) >= '3.0':
while calling '_is_glibc_older_than_2_25_on_linux', line 519
        libver = platform.libc_ver()
        OSError: [Errno 22] Invalid argument: 'C:\\Users\\Very Smart PC\\AppData\\Local\\Microsoft\\WindowsApps\\PythonSoftwareFoundation.Python.3.12_qbz5n2kfra8p0\\python.exe'
  1. After skipping _is_glibc_older_than_2_25_on_linux checking, configure.py script won't generate MAKEFILE because of the blanks in my prefix path.
PS C:\Users\Very Smart PC\project> conan install -b missing -s build_type=Debug .

======== Input profiles ========
Profile host:
[settings]
arch=x86_64
build_type=Debug
compiler=msvc
compiler.cppstd=14
compiler.runtime=dynamic
compiler.runtime_type=Debug
compiler.version=193
os=Windows
botan/*:compiler.cppstd=20

Profile build:
[settings]
arch=x86_64
build_type=Debug
compiler=msvc
compiler.cppstd=14
compiler.runtime=dynamic
compiler.runtime_type=Debug
compiler.version=193
os=Windows
botan/*:compiler.cppstd=20


======== Computing dependency graph ========
Graph root
    conanfile.txt: C:\Users\Very Smart PC\project\conanfile.txt
Requirements
    botan/3.4.0#3a6670dd6800e6586f8bf616a0e787dd - Cache
Resolved version ranges
    botan/[>=3.0.0]: botan/3.4.0

======== Computing necessary packages ========
botan/3.4.0: Checking 1 compatible configurations
botan/3.4.0: Compatible configurations not found in cache, checking servers
botan/3.4.0: 'd4cc82bcf7e95967bec87ec25b73e6607ac01cb4': compiler.cppstd=23
Requirements
    botan/3.4.0#3a6670dd6800e6586f8bf616a0e787dd:ff8fca64e2d4cc62769a2e60abab7543b6fc9101 - Build

======== Installing packages ========

-------- Installing package botan/3.4.0 (1 of 1) --------
botan/3.4.0: Building from source
botan/3.4.0: Package botan/3.4.0:ff8fca64e2d4cc62769a2e60abab7543b6fc9101
botan/3.4.0: Copying sources to build folder
botan/3.4.0: Building your package in C:\Users\Very Smart PC\.conan2\p\b\botanc0cd54e8ab684\b
botan/3.4.0: Calling generate()
botan/3.4.0: Generators folder: C:\Users\Very Smart PC\.conan2\p\b\botanc0cd54e8ab684\b\build-debug\conan
botan/3.4.0: Generating aggregated env files
botan/3.4.0: Generated aggregated env files: ['conanbuild.bat', 'conanrun.bat']
botan/3.4.0: Calling build()
botan/3.4.0: apply_conandata_patches(): No patches defined in conandata
botan/3.4.0: RUN: python ./configure.py --build-targets=static --distribution-info="Conan" --without-documentation --cc-abi-flags=" " --extra-cxxflags=" " --cc=msvc --cpu=x86_64 --prefix=C:\Users\Very Smart PC\.conan2\p\b\botanc0cd54e8ab684\p --os=windows --amalgamation --debug-mode --msvc-runtime=MDd --without-pkg-config
conanvcvars.bat: Activating environment Visual Studio 17 - amd64 - winsdk_version=None - vcvars_ver=14.3
[vcvarsall.bat] Environment initialized for: 'x64'
ERROR:root:Unhandled option(s): Smart PC\.conan2\p\b\botanc0cd54e8ab684\p

botan/3.4.0: RUN: nmake
conanvcvars.bat: Activating environment Visual Studio 17 - amd64 - winsdk_version=None - vcvars_ver=14.3
[vcvarsall.bat] Environment initialized for: 'x64'

Microsoft (R) Program Maintenance Utility Version 14.39.33521.0
Copyright (C) Microsoft Corporation.  All rights reserved.

NMAKE : fatal error U1064: MAKEFILE not found and no target specified
Stop.

botan/3.4.0: ERROR: 
Package 'ff8fca64e2d4cc62769a2e60abab7543b6fc9101' build failed
botan/3.4.0: WARN: Build folder C:\Users\Very Smart PC\.conan2\p\b\botanc0cd54e8ab684\b\build-debug
ERROR: botan/3.4.0: Error in build() method, line 249
        self.run(self._make_cmd)
        ConanException: Error 2 while executing
  1. Here's the succeeded one after applying this PR.
PS C:\Users\Very Smart PC\project> conan install -b missing -s build_type=Debug .

======== Input profiles ========
Profile host:
[settings]
arch=x86_64
build_type=Debug
compiler=msvc
compiler.cppstd=14
compiler.runtime=dynamic   
compiler.runtime_type=Debug
compiler.version=193       
os=Windows
botan/*:compiler.cppstd=20 

Profile build:
[settings]
arch=x86_64
build_type=Debug
compiler=msvc
compiler.cppstd=14
compiler.runtime=dynamic   
compiler.runtime_type=Debug
compiler.version=193       
os=Windows
botan/*:compiler.cppstd=20 


======== Computing dependency graph ========
Graph root
    conanfile.txt: C:\Users\Very Smart PC\project\conanfile.txt
Requirements
    botan/3.4.0#3a6670dd6800e6586f8bf616a0e787dd - Cache
Resolved version ranges
    botan/[>=3.0.0]: botan/3.4.0

======== Computing necessary packages ========
botan/3.4.0: Checking 1 compatible configurations
botan/3.4.0: Compatible configurations not found in cache, checking servers
botan/3.4.0: 'd4cc82bcf7e95967bec87ec25b73e6607ac01cb4': compiler.cppstd=23
Requirements
    botan/3.4.0#3a6670dd6800e6586f8bf616a0e787dd:ff8fca64e2d4cc62769a2e60abab7543b6fc9101 - Build

======== Installing packages ========

-------- Installing package botan/3.4.0 (1 of 1) --------
botan/3.4.0: Building from source
botan/3.4.0: Package botan/3.4.0:ff8fca64e2d4cc62769a2e60abab7543b6fc9101
botan/3.4.0: Copying sources to build folder
botan/3.4.0: Building your package in C:\Users\Very Smart PC\.conan2\p\b\botand0e5336d12b5d\b
botan/3.4.0: Calling generate()
botan/3.4.0: Generators folder: C:\Users\Very Smart PC\.conan2\p\b\botand0e5336d12b5d\b\build-debug\conanbotan/3.4.0: Generating aggregated env files
botan/3.4.0: Generated aggregated env files: ['conanbuild.bat', 'conanrun.bat']
botan/3.4.0: Calling build()
botan/3.4.0: apply_conandata_patches(): No patches defined in conandata
botan/3.4.0: RUN: python ./configure.py --build-targets=static --distribution-info="Conan" --without-documentation --cc-abi-flags=" " --extra-cxxflags=" " --cc=msvc --cpu=x86_64 --prefix="C:\Users\Very Smart PC\.conan2\p\b\botand0e5336d12b5d\p" --os=windows --amalgamation --debug-mode --msvc-runtime=MDd --without-pkg-config
conanvcvars.bat: Activating environment Visual Studio 17 - amd64 - winsdk_version=None - vcvars_ver=14.3
[vcvarsall.bat] Environment initialized for: 'x64'
   INFO: ./configure.py invoked with options "--build-targets=static --distribution-info=Conan --without-documentation --cc-abi-flags=  --extra-cxxflags=  --cc=msvc --cpu=x86_64 --prefix=C:\Users\Very Smart PC\.conan2\p\b\botand0e5336d12b5d\p --os=windows --amalgamation --debug-mode --msvc-runtime=MDd --without-pkg-config"
   INFO: Configuring to build Botan 3.4.0 (revision unknown)
   INFO: Python version: "3.12.3 (tags/v3.12.3:f6650f9, Apr  9 2024, 14:05:25) [MSC v.1938 64 bit (AMD64)]"
   INFO: Autodetected platform information: OS="Windows" machine="AMD64" proc="Intel64 Family 6 Model 158 Stepping 9, GenuineIntel"
   INFO: Auto-detected compiler version msvc 19.39
   INFO: Auto-detected compiler arch x86_64
   INFO: Target is msvc:19.39-windows-x86_64
   INFO: Assuming target x86_64 is little endian
   INFO: Skipping (dependency failure): asio certstor_sqlite3 sessions_sqlite3
   INFO: Skipping (incompatible CPU): aes_armv8 aes_power8 sha1_armv8 sha2_32_armv8 sha2_64_armv8 shacal2_armv8 sm4_armv8
   INFO: Skipping (incompatible OS): certstor_system_macos commoncrypto fd_unix getentropy
   INFO: Skipping (incompatible compiler): argon2_ssse3 keccak_perm_bmi2 serpent_avx2 serpent_avx512 sha2_32_bmi2 sha2_64_bmi2
   INFO: Skipping (no enabled compression schemes): compression
   INFO: Skipping (requires external dependency): boost bzip2 lzma sqlite3 tpm zlib
   INFO: Loading modules: adler32 aead aes aes_crystals_xof aes_ni aes_vperm argon2 argon2_avx2 argon2fmt aria asn1 auto_rng base base32 base58 base64 bcrypt bcrypt_pbkdf bigint blake2 blake2mac blake2s block blowfish 
camellia cascade cast128 cbc ccm certstor_flatfile certstor_sql certstor_system certstor_system_windows cfb chacha chacha20poly1305 chacha_avx2 chacha_avx512 chacha_rng chacha_simd32 checksum cmac comb4p cpuid crc24 crc32 cryptobox cshake_xof ctr curve25519 curve448 des dh dilithium dilithium_aes dilithium_common dl_algo dl_group dlies dsa dyn_load eax ec_group ec_h2c ecc_key ecdh ecdsa ecgdsa ecies eckcdsa ed25519 ed448 elgamal eme_oaep eme_pkcs1 eme_raw emsa_pkcs1 emsa_pssr emsa_raw emsa_x931 entropy ffi filters fpe_fe1 frodokem frodokem_aes frodokem_common gcm ghash ghash_cpu ghash_vperm gmac gost_28147 gost_3410 gost_3411 hash hash_id hex hkdf hmac hmac_drbg hotp http_util idea idea_sse2 iso9796 kdf kdf1 kdf1_iso18033 kdf2 keccak keccak_perm keypair kmac kuznyechik kyber kyber_90s kyber_common lion locking_allocator mac mce md4 md5 mdx_hash mem_pool mgf1 mode_pad modes mp nist_keywrap noekeon noekeon_simd numbertheory ocb ofb par_hash passhash9 pbes2 pbkdf pbkdf2 pem pgp_s2k pk_pad pkcs11 poly1305 poly_dbl prf_tls prf_x942 processor_rng psk_db pubkey raw_hash rc4 rdseed rfc3394 rfc6979 rmd160 rng roughtime rsa salsa20 scrypt seed serpent serpent_simd sessions_sql sha1 sha1_sse2 sha1_x86 sha2_32 sha2_32_x86 sha2_64 sha3 shacal2 shacal2_avx2 shacal2_simd shacal2_x86 shake shake_cipher 
shake_xof simd simd_avx2 simd_avx512 siphash siv skein sm2 sm3 sm4 socket sodium sp800_108 sp800_56a sp800_56c sphincsplus_common sphincsplus_sha2 sphincsplus_shake srp6 stateful_rng stream streebog system_rng thread_utils threefish_512 tls tls12 tls13 tls13_pqc tls_cbc trunc_hash tss twofish utils uuid whirlpool win32_stats 
x448 x509 x919_mac xmd xmss xof xts zfec zfec_sse2 zfec_vperm
   INFO: Using copy to link files into build dir (use --link-method to change)
   INFO: Writing amalgamation header to botan_all.h
   INFO: Writing amalgamation source to botan_all.cpp
   INFO: Botan 3.4.0 (revision unknown) (unreleased undated) build setup is complete

botan/3.4.0: RUN: nmake
conanvcvars.bat: Activating environment Visual Studio 17 - amd64 - winsdk_version=None - vcvars_ver=14.3
[vcvarsall.bat] Environment initialized for: 'x64'

Microsoft (R) Program Maintenance Utility Version 14.39.33521.0
Copyright (C) Microsoft Corporation.  All rights reserved.

        cl /Fdbuild/botan-3.pdb  /std:c++20 /EHs /GR /D_WIN32_WINNT=0x0600 /MDd /bigobj   /Zi /FS /W4 /wd4251 /wd4275 /wd5072 -DBOTAN_IS_BEING_BUILT  /I build/include/public /I build/include/internal  /external:W0 /external:I build/include/external /nologo /c botan_all.cpp /Fobuild/obj/lib/botan_all.obj
botan_all.cpp
C:\Users\Very Smart PC\.conan2\p\b\botand0e5336d12b5d\b\src\botan_all.cpp(52613) : warning C4702: unreachable code
C:\Users\Very Smart PC\.conan2\p\b\botand0e5336d12b5d\b\src\botan_all.cpp(19968) : warning C4702: unreachable code
C:\Users\Very Smart PC\.conan2\p\b\botand0e5336d12b5d\b\src\botan_all.cpp(19968) : warning C4702: unreachable code
C:\Users\Very Smart PC\.conan2\p\b\botand0e5336d12b5d\b\src\botan_all.cpp(19968) : warning C4702: unreachable code
C:\Users\Very Smart PC\.conan2\p\b\botand0e5336d12b5d\b\src\botan_all.cpp(19968) : warning C4702: unreachable code
C:\Users\Very Smart PC\.conan2\p\b\botand0e5336d12b5d\b\src\botan_all.cpp(19968) : warning C4702: unreachable code
C:\Users\Very Smart PC\.conan2\p\b\botand0e5336d12b5d\b\src\botan_all.cpp(19968) : warning C4702: unreachable code
C:\Users\Very Smart PC\.conan2\p\b\botand0e5336d12b5d\b\src\botan_all.cpp(19968) : warning C4702: unreachable code
C:\Users\Very Smart PC\.conan2\p\b\botand0e5336d12b5d\b\src\botan_all.cpp(19968) : warning C4702: unreachable code
C:\Users\Very Smart PC\.conan2\p\b\botand0e5336d12b5d\b\src\botan_all.cpp(19980) : warning C4702: unreachable code
C:\Users\Very Smart PC\.conan2\p\b\botand0e5336d12b5d\b\src\botan_all.cpp(19980) : warning C4702: unreachable code
C:\Users\Very Smart PC\.conan2\p\b\botand0e5336d12b5d\b\src\botan_all.cpp(19968) : warning C4702: unreachable code
C:\Users\Very Smart PC\.conan2\p\b\botand0e5336d12b5d\b\src\botan_all.cpp(19968) : warning C4702: unreachable code
C:\Users\Very Smart PC\.conan2\p\b\botand0e5336d12b5d\b\src\botan_all.cpp(19968) : warning C4702: unreachable code
C:\Users\Very Smart PC\.conan2\p\b\botand0e5336d12b5d\b\src\botan_all.cpp(19968) : warning C4702: unreachable code
C:\Users\Very Smart PC\.conan2\p\b\botand0e5336d12b5d\b\src\botan_all.cpp(19968) : warning C4702: unreachable code
C:\Users\Very Smart PC\.conan2\p\b\botand0e5336d12b5d\b\src\botan_all.cpp(19980) : warning C4702: unreachable code
        lib /nologo /OUT:./botan-3.lib build/obj/lib/botan_all.obj

botan/3.4.0: Package 'ff8fca64e2d4cc62769a2e60abab7543b6fc9101' built
botan/3.4.0: Build folder C:\Users\Very Smart PC\.conan2\p\b\botand0e5336d12b5d\b\build-debug
botan/3.4.0: Generating the package
botan/3.4.0: Packaging in folder C:\Users\Very Smart PC\.conan2\p\b\botand0e5336d12b5d\p
botan/3.4.0: Calling package()
botan/3.4.0: RUN: nmake install
conanvcvars.bat: Activating environment Visual Studio 17 - amd64 - winsdk_version=None - vcvars_ver=14.3
[vcvarsall.bat] Environment initialized for: 'x64'

Microsoft (R) Program Maintenance Utility Version 14.39.33521.0
Copyright (C) Microsoft Corporation.  All rights reserved.

        "C:/Users/Very Smart PC/AppData/Local/Microsoft/WindowsApps/PythonSoftwareFoundation.Python.3.12_qbz5n2kfra8p0/python.exe" "src/scripts/install.py" --build-dir="build"
   INFO: Botan 3.4.0 installation to C:\Users\Very Smart PC\.conan2\p\b\botand0e5336d12b5d\p complete

botan/3.4.0: package(): Packaged 166 '.h' files
botan/3.4.0: package(): Packaged 1 '.lib' file: botan-3.lib
botan/3.4.0: package(): Packaged 2 '.cmake' files: botan-config-version.cmake, botan-config.cmake
botan/3.4.0: package(): Packaged 1 '.txt' file: license.txt
botan/3.4.0: Created package revision f1313402903087aca061a6c4c8fc9c14
botan/3.4.0: Package 'ff8fca64e2d4cc62769a2e60abab7543b6fc9101' created
botan/3.4.0: Full package reference: botan/3.4.0#3a6670dd6800e6586f8bf616a0e787dd:ff8fca64e2d4cc62769a2e60abab7543b6fc9101#f1313402903087aca061a6c4c8fc9c14
botan/3.4.0: Package folder C:\Users\Very Smart PC\.conan2\p\b\botand0e5336d12b5d\p

======== Finalizing install (deploy, generators) ========
conanfile.txt: Writing generators to C:\Users\Very Smart PC\project\build\generators
conanfile.txt: Generator 'CMakeDeps' calling 'generate()'
conanfile.txt: CMakeDeps necessary find_package() and targets for your CMakeLists.txt
    find_package(botan)
    target_link_libraries(... botan::botan)
conanfile.txt: Generator 'CMakeToolchain' calling 'generate()'
conanfile.txt: CMakeToolchain generated: conan_toolchain.cmake
conanfile.txt: Preset 'conan-default' added to CMakePresets.json. Invoke it manually using 'cmake --preset conan-default' if using CMake>=3.23
conanfile.txt: If your CMake version is not compatible with CMakePresets (<3.23) call cmake like: 'cmake <path> -G "Visual Studio 17 2022" -DCMAKE_TOOLCHAIN_FILE=C:\Users\Very Smart PC\project\build\generators\conan_toolchain.cmake -DCMAKE_POLICY_DEFAULT_CMP0091=NEW'
conanfile.txt: CMakeToolchain generated: CMakePresets.json
conanfile.txt: CMakeToolchain generated: ..\..\CMakeUserPresets.json
conanfile.txt: Generating aggregated env files
conanfile.txt: Generated aggregated env files: ['conanbuild.bat', 'conanrun.bat']
Install finished successfully

I hope the information above could be helpful.

@CLAassistant
Copy link

CLAassistant commented Apr 24, 2024

CLA assistant check
All committers have signed the CLA.

@pichi-router
Copy link
Contributor Author

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
Pichi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

My previous email address is unavailable any more. I'm gonna re-submit the commit with a correct email.

@conan-center-bot

This comment has been minimized.

- avoid configure.py failure when prefix path contains space
- avoid the exception raised by platform.libc_ver() when python was installed by Windows Store
@conan-center-bot

This comment has been minimized.

@jcar87
Copy link
Contributor

jcar87 commented Jun 19, 2024

This build was successful but the status check was not reported back to GitHub - will be updated shortly

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 4 (f5aa45bf1241815611916074f161a164a76270b6):

  • botan/2.19.2:
    All packages built successfully! (All logs)

  • botan/2.18.2:
    All packages built successfully! (All logs)

  • botan/2.17.3:
    All packages built successfully! (All logs)

  • botan/3.3.0:
    All packages built successfully! (All logs)

  • botan/2.19.3:
    All packages built successfully! (All logs)

  • botan/2.19.4:
    All packages built successfully! (All logs)

  • botan/3.4.0:
    All packages built successfully! (All logs)

  • botan/2.19.1:
    All packages built successfully! (All logs)

  • botan/3.1.0:
    All packages built successfully! (All logs)

  • botan/3.1.1:
    All packages built successfully! (All logs)

  • botan/3.0.0:
    All packages built successfully! (All logs)

  • botan/3.2.0:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 2 (f5aa45bf1241815611916074f161a164a76270b6):

  • botan/2.17.3:
    All packages built successfully! (All logs)

  • botan/2.19.1:
    All packages built successfully! (All logs)

  • botan/2.19.2:
    All packages built successfully! (All logs)

  • botan/2.18.2:
    All packages built successfully! (All logs)

  • botan/2.19.3:
    All packages built successfully! (All logs)

  • botan/3.3.0:
    All packages built successfully! (All logs)

  • botan/2.19.4:
    All packages built successfully! (All logs)

  • botan/3.1.0:
    All packages built successfully! (All logs)

  • botan/3.4.0:
    All packages built successfully! (All logs)

  • botan/3.0.0:
    All packages built successfully! (All logs)

  • botan/3.2.0:
    All packages built successfully! (All logs)

  • botan/3.1.1:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 3f6deea into conan-io:master Jun 19, 2024
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants