Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update qcustomplot recipe to be compatible with Conan 2 #23645

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

anton-danielsson
Copy link
Contributor

@anton-danielsson anton-danielsson commented Apr 18, 2024

Specify library name and version: qcustomplot /all

Make necessary changes to the qcustomplot to make it compatible with Conan 2.


@CLAassistant
Copy link

CLAassistant commented Apr 18, 2024

CLA assistant check
All committers have signed the CLA.

@conan-center-bot conan-center-bot added Failed Version conflict There is a version conflict when solving the dependencies graph labels Apr 18, 2024
@conan-center-bot

This comment has been minimized.

@conan-center-bot conan-center-bot added the Missing dependencies Build failed due missing dependencies in Conan Center label Apr 18, 2024
@conan-center-bot

This comment has been minimized.

@anton-danielsson anton-danielsson force-pushed the feature/update-qcustomplot branch from 3d3ef9a to a353cbf Compare April 18, 2024 17:43
This reverts commit 64370d3.
@conan-center-bot conan-center-bot removed Missing dependencies Build failed due missing dependencies in Conan Center Version conflict There is a version conflict when solving the dependencies graph labels Apr 18, 2024
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@valgur
Copy link
Contributor

valgur commented Apr 19, 2024

Needs a

def build_requirements(self):
    self.tool_requires("<host_version>")

and a VirtualBuildEnv generator for moc to be found.

@anton-danielsson
Copy link
Contributor Author

Needs a

def build_requirements(self):
    self.tool_requires("<host_version>")

and a VirtualBuildEnv generator for moc to be found.

Alright, see: f821f4b

@conan-center-bot

This comment has been minimized.

@anton-danielsson
Copy link
Contributor Author

anton-danielsson commented Apr 19, 2024

Needs a

def build_requirements(self):
    self.tool_requires("<host_version>")

and a VirtualBuildEnv generator for moc to be found.

Could reproduce this locally now. I only tested static before.
Tested now with: conan create . --version 2.1.1 --channel foo --user bar -o */*:shared=True

I had to add: VirtualRunEnv(self).generate(scope="build") to get it working.

@conan-center-bot

This comment has been minimized.

@valgur
Copy link
Contributor

valgur commented Apr 19, 2024

I had to add: VirtualRunEnv(self).generate(scope="build") to get it working.

Ah right, that's required for Qt DLLs to be found during build.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 11 (0c60d26530d70e020cac75947ffc9b58a1e1c1f5):

  • qcustomplot/2.1.0:
    All packages built successfully! (All logs)

  • qcustomplot/2.1.1:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 11 (0c60d26530d70e020cac75947ffc9b58a1e1c1f5):

  • qcustomplot/2.1.1:
    All packages built successfully! (All logs)

  • qcustomplot/2.1.0:
    All packages built successfully! (All logs)

Comment on lines +54 to +55
if self.settings.os == "Macos":
raise ConanInvalidConfiguration(f"{self.ref} Macos not supported at this moment")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me check this on Monday, maybe we can help keep macos support seeing the error the bot reported :)

Copy link
Contributor

@ericLemanissier ericLemanissier Apr 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error is actually in qt recipe, which does not properly define frameworks needed by qtgui. It could be solved by my other qt PR #23571, so let's wait for it to be merged before retrying this one

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any updates on the #23571 PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need some help on how to proceed with this after #23571 was abandoned.

@AbrilRBS AbrilRBS self-assigned this Apr 20, 2024
@anton-danielsson
Copy link
Contributor Author

@RubenRBS @valgur Need assistance on how to proceed with this PR.

@conan-center-bot conan-center-bot requested a review from jcar87 July 26, 2024 11:38
@AbrilRBS AbrilRBS removed their assignment Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants