-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update qcustomplot recipe to be compatible with Conan 2 #23645
base: master
Are you sure you want to change the base?
Update qcustomplot recipe to be compatible with Conan 2 #23645
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Very old, last 1.3.2 is from 2015.
3d3ef9a
to
a353cbf
Compare
This reverts commit 64370d3.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Needs a def build_requirements(self):
self.tool_requires("<host_version>") and a |
Alright, see: f821f4b |
This comment has been minimized.
This comment has been minimized.
Could reproduce this locally now. I only tested static before. I had to add: |
This comment has been minimized.
This comment has been minimized.
Ah right, that's required for Qt DLLs to be found during build. |
Conan v1 pipeline ✔️All green in build 11 (
Conan v2 pipeline ✔️
All green in build 11 ( |
if self.settings.os == "Macos": | ||
raise ConanInvalidConfiguration(f"{self.ref} Macos not supported at this moment") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me check this on Monday, maybe we can help keep macos support seeing the error the bot reported :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error is actually in qt recipe, which does not properly define frameworks needed by qtgui. It could be solved by my other qt PR #23571, so let's wait for it to be merged before retrying this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any updates on the #23571 PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need some help on how to proceed with this after #23571 was abandoned.
@RubenRBS @valgur Need assistance on how to proceed with this PR. |
Specify library name and version: qcustomplot /all
Make necessary changes to the qcustomplot to make it compatible with Conan 2.