zxcvbn: added recipe for version 2.5 #23671
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
laci-aura
force-pushed
the
laci-aura/add-zxcvbn-c-recipe
branch
from
30ae413
to
0254ad0
Compare
This comment has been minimized.
This comment has been minimized.
laci-aura
force-pushed
the
laci-aura/add-zxcvbn-c-recipe
branch
from
0254ad0
to
a6c5db3
Compare
This comment has been minimized.
This comment has been minimized.
laci-aura
force-pushed
the
laci-aura/add-zxcvbn-c-recipe
branch
from
a6c5db3
to
6a6e83b
Compare
This comment has been minimized.
This comment has been minimized.
laci-aura
force-pushed
the
laci-aura/add-zxcvbn-c-recipe
branch
2 times, most recently
from
e05d00d
to
0211201
Compare
This comment has been minimized.
This comment has been minimized.
laci-aura
force-pushed
the
laci-aura/add-zxcvbn-c-recipe
branch
from
0211201
to
d1b3258
Compare
laci-aura
changed the title
laci-aura
force-pushed
the
laci-aura/add-zxcvbn-c-recipe
branch
from
d1b3258
to
f4a9ded
Compare
This comment has been minimized.
This comment has been minimized.
laci-aura
force-pushed
the
laci-aura/add-zxcvbn-c-recipe
branch
from
f4a9ded
to
a5f9742
Compare
This comment has been minimized.
This comment has been minimized.
laci-aura
force-pushed
the
laci-aura/add-zxcvbn-c-recipe
branch
from
a5f9742
to
619b058
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 12 (
Conan v2 pipeline ✔️
All green in build 12 (
|
AbrilRBS
reviewed
Nov 21, 2024
Comment on lines
+27
to
+29
| def build_requirements(self): | ||
| if cross_building(self): | ||
| self.tool_requires(f"{self.name}/{self.version}") |
There was a problem hiding this comment.
Any insight into why this is needed? From what I can gather, cross compiling should not need to depend on the library itself
Comment on lines
+64
to
+69
| if cross_building(self): | ||
| self._patch_if_exists("no-dictgen") | ||
| if self.settings.os not in ["Linux", "FreeBSD"]: | ||
| self._patch_if_exists("no-libm") | ||
| if self.settings.os == "Windows": | ||
| self._patch_if_exists("windows-portability") |
There was a problem hiding this comment.
Patches should not be conditional, the sources should be modified unconditionally if possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zxcvbn/2.5
C/C++ implementation of the zxcvbn password strength estimation.