-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libosmium: new recipe #23720
base: master
Are you sure you want to change the base?
libosmium: new recipe #23720
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Can't approve because I ran out of time for a proper review for the day, but from a glance looks good :)
|
||
int main() { | ||
try { | ||
const osmium::io::File input_file{"missing_file.pbf"}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice idea with passing a missing file, very on topic with the simplification of the test packages :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I see a minor issue with zlib, other than that, I have checked that this properly links to gdal locally too, so I think it's good to go :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra question: is the gdalcpp vendorizen library something we should worry about?
This comment has been minimized.
This comment has been minimized.
Requires conan-io#23829.
@RubenRBS Thanks for pointing it out. I did not notice that it's a vendored external library. I turned it into a separate package: #23829. |
Conan v1 pipeline ✔️All green in build 4 (
Conan v2 pipeline ✔️
All green in build 4 (
|
any chance we can get this merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When trying to compile with all options set to false, I get this in the test_package:
-- Configuring done (0.8s)
-- Generating done (0.0s)
-- Build files have been written to: /Users/abril/coding/conan-center-index/recipes/libosmium/all/test_package/build/apple-clang-16-armv8-gnu17-release
libosmium/2.20.0 (test package): Running CMake.build()
libosmium/2.20.0 (test package): RUN: cmake --build "/Users/abril/coding/conan-center-index/recipes/libosmium/all/test_package/build/apple-clang-16-armv8-gnu17-release" -- -j12
[ 50%] Building CXX object CMakeFiles/test_package.dir/test_package.cpp.o
In file included from /Users/abril/coding/conan-center-index/recipes/libosmium/all/test_package/test_package.cpp:1:
In file included from /Users/abril/.conan2/p/b/libos33eefa4f13402/p/include/osmium/io/any_input.hpp:48:
In file included from /Users/abril/.conan2/p/b/libos33eefa4f13402/p/include/osmium/io/o5m_input.hpp:42:
/Users/abril/.conan2/p/b/libos33eefa4f13402/p/include/osmium/io/detail/o5m_input_format.hpp:56:10: fatal error: 'protozero/exception.hpp' file not found
56 | #include <protozero/exception.hpp>
| ^~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
make[2]: *** [CMakeFiles/test_package.dir/test_package.cpp.o] Error 1
make[1]: *** [CMakeFiles/test_package.dir/all] Error 2
make: *** [all] Error 2
ERROR: libosmium/2.20.0 (test package): Error in build() method, line 22
cmake.build()
ConanException: Error 2 while executing
which seems to imply that either pbf
is non-optional, or that its presence is not properly propagated
Thank you for the extra checks. 🙂 I was using functionality from the optional |
Uhm... how should I handle this? Also, I don't have any plans to open new PRs in addition to the existing ones any time soon (although I do have another couple hundred potential ones left in the tank - mostly minor recipe bug fixes related to cross-compilation support).
|
@valgur thanks for fixing the issues! Right now no PRs are running by default, and we are triggering them by hand at first to get a handle of how the new CI behaves, regardless of how many prs the author has opened :) I'll launch this one now, thanks! |
Adds libosmium: https://github.com/osmcode/libosmium
Fast and flexible C++ library for working with OpenStreetMap data.
Requires #23829 for the gdal option to be able to be set to True