Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glfw: use dependencies.build instead of deps_cpp_info #23779

Merged

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Apr 26, 2024

Prefer dependencies.build instead of deps_cpp_info for the workaround related to generation of wayland-protocols pkgconf file from build context in case of 1 profile (see #21242 (comment))

/cc @uilianries


Copy link
Contributor

🤖 Beep Boop! This pull request is making changes to 'recipes/glfw//'.

👋 @Hopobcn you might be interested. 😉

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 1 (d5a9e6802a8e537a0de79903711c4e389c358dec):

  • glfw/3.4:
    All packages built successfully! (All logs)

  • glfw/3.3.8:
    All packages built successfully! (All logs)

  • glfw/3.3.6:
    All packages built successfully! (All logs)

  • glfw/3.3.7:
    All packages built successfully! (All logs)

  • glfw/3.3.3:
    All packages built successfully! (All logs)

  • glfw/3.3.2:
    All packages built successfully! (All logs)

  • glfw/3.3.4:
    All packages built successfully! (All logs)

  • glfw/3.3.5:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 1 (d5a9e6802a8e537a0de79903711c4e389c358dec):

  • glfw/3.4:
    All packages built successfully! (All logs)

  • glfw/3.3.8:
    All packages built successfully! (All logs)

  • glfw/3.3.6:
    All packages built successfully! (All logs)

  • glfw/3.3.4:
    All packages built successfully! (All logs)

  • glfw/3.3.3:
    All packages built successfully! (All logs)

  • glfw/3.3.2:
    All packages built successfully! (All logs)

  • glfw/3.3.5:
    All packages built successfully! (All logs)

  • glfw/3.3.7:
    All packages built successfully! (All logs)

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have some reported issue for these PRs, or are we expecting them to have the same issue as the original one and are preemtemply fixing it?
As far as I can see, there's no 3rd PR triggering the same case as the original PR you link, but happy to get some more insight :)

@AbrilRBS AbrilRBS self-assigned this Apr 30, 2024
@memsharded memsharded self-assigned this Jun 11, 2024
@conan-center-bot conan-center-bot merged commit 5b1dc27 into conan-io:master Jun 11, 2024
49 checks passed
@SpaceIm SpaceIm deleted the glfw/prefer-dependencies-build branch September 30, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants