-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CMakeFile for ohPipeline #23788
Update CMakeFile for ohPipeline #23788
Conversation
This comment has been minimized.
This comment has been minimized.
BTW: if there is a better way to handle the ServiceGen path handover than this: https://github.com/conan-io/conan-center-index/blob/master/recipes/ohnet/all/conanfile.py#L113 I'd be happy to learn. Somehow this feels extremely hacky. |
@@ -4,8 +4,8 @@ sources: | |||
url: "https://github.com/openhome/ohPipeline/archive/refs/tags/ohMediaPlayer_1.139.1000.tar.gz" | |||
sha256: "070eac6d974bbe520d0b292df1ca4a72160a2b607a60dabdaa0971c3ef96e5e4" | |||
cmake: | |||
url: "https://raw.githubusercontent.com/merakiacoustic/ohPipeline/ohMediaPlayer_1.139.1000_meraki2/CMakeLists.txt" | |||
sha256: "f9e11d4adb8426a8375dae02e3b641d66efc6ef3abd6f96cb81f6e85352083a3" | |||
url: "https://raw.githubusercontent.com/merakiacoustic/ohPipeline/ohMediaPlayer_1.139.1000_meraki3/CMakeLists.txt" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needing to maintain a completely custom build system for a project is already a nightmare, but even more so when externalizing the scripts. I am not sure why this was accepted.
If it is too big to be included in CCI's repository, it is too big to be maintained. Can we please integrate it back here or have a general discussion about this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've also created a separate PR that tries to work with existing build system but it fails in ways I can't reproduce :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree this should be done, but I know it can be complicated too.
So approving this fix in the meantime, thanks very much for contributing it @DoomHammer !
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 5 (
Conan v2 pipeline ✔️
All green in build 5 (
|
CMAKE_BUILD_TYPE is apparently not set in Windows builds. The new approach should handle this.