-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tar: add version 1.35 #23806
tar: add version 1.35 #23806
Conversation
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 2 (
Conan v2 pipeline ✔️
All green in build 2 ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thanks a lot for taking the time to make sure this one works :)
I have a minor question checking the version checks, otherwise looks good
self.requires("zstd/1.5.5", run=True, headers=False, libs=False) | ||
# self.requires("lzo/2.10", run=True, headers=False, libs=False) | ||
|
||
def build_requirements(self): | ||
if Version(self.version) == "1.35": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this not expected to be needed in the future? We might save a compilation if the check in the future includes the new versions :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only needed because autoreconf needs to be called after patching a Makefile.am file.
Given the patch comes from the main branch of tar, it's not expected that this will be needed in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RubenRBS, do you need more information ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, sorry I missed this ping :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Specify library name and version: tar/1.35
Add version 1.35
bump xz_utils to 5.4.5
All versions < 1.35 have known security issues: https://repology.org/project/tar/information