Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tar: add version 1.35 #23806

Merged
merged 2 commits into from
Jun 6, 2024
Merged

tar: add version 1.35 #23806

merged 2 commits into from
Jun 6, 2024

Conversation

mayeut
Copy link
Contributor

@mayeut mayeut commented Apr 29, 2024

Specify library name and version: tar/1.35

Add version 1.35
bump xz_utils to 5.4.5

All versions < 1.35 have known security issues: https://repology.org/project/tar/information


@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 2 (93b4a986a0c4a345f0c365860bcd42e39afdeb96):

  • tar/1.32.90:
    All packages built successfully! (All logs)

  • tar/1.35:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 2 (93b4a986a0c4a345f0c365860bcd42e39afdeb96):

  • tar/1.35:
    All packages built successfully! (All logs)

  • tar/1.32.90:
    All packages built successfully! (All logs)

@AbrilRBS AbrilRBS self-assigned this Apr 30, 2024
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks a lot for taking the time to make sure this one works :)

I have a minor question checking the version checks, otherwise looks good

self.requires("zstd/1.5.5", run=True, headers=False, libs=False)
# self.requires("lzo/2.10", run=True, headers=False, libs=False)

def build_requirements(self):
if Version(self.version) == "1.35":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not expected to be needed in the future? We might save a compilation if the check in the future includes the new versions :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only needed because autoreconf needs to be called after patching a Makefile.am file.
Given the patch comes from the main branch of tar, it's not expected that this will be needed in the future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RubenRBS, do you need more information ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, sorry I missed this ping :/

@mayeut mayeut requested a review from AbrilRBS May 28, 2024 05:58
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@conan-center-bot conan-center-bot merged commit 3cd8b27 into conan-io:master Jun 6, 2024
18 checks passed
@mayeut mayeut deleted the tar-1.35 branch June 6, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants