cpptrace: Conanfile tidying #23821
cpptrace: Conanfile tidying #23821
Conversation
jeremy-rifkin
changed the title
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jeremy-rifkin
changed the title
This comment has been minimized.
This comment has been minimized.
ghost
mentioned this pull request
|
I detected other pull requests that are modifying cpptrace/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
|
Thank you! I've updated the PR |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
I have some issues compiling in Linux with libunwind and *:shared=True, could you please take a look @jeremy-rifkin? Thanks :)
The error seems to be in the test package, some missing symbols seems to be the main issue:
# conan create . --version=0.5.4 -b=missing -o="unwind=libunwind" -o="*:shared=True"
======== Exporting recipe to the cache ========
cpptrace/0.5.4: Exporting package recipe: /cpptrace/conanfile.py
cpptrace/0.5.4: exports: File 'conandata.yml' found. Exporting it...
cpptrace/0.5.4: Calling export_sources()
cpptrace/0.5.4: Copied 1 '.yml' file: conandata.yml
cpptrace/0.5.4: Copied 1 '.py' file: conanfile.py
cpptrace/0.5.4: Exported to cache folder: /root/.conan2/p/cpptr466431496c4c6/e
cpptrace/0.5.4: Exported: cpptrace/0.5.4#2c7f75faefb5c7a7941a8038a88eb3d7 (2024-05-04 23:38:09 UTC)
======== Input profiles ========
Profile host:
[settings]
arch=armv8
build_type=Release
compiler=gcc
compiler.cppstd=gnu17
compiler.libcxx=libstdc++11
compiler.version=11
os=Linux
[options]
unwind=libunwind
*:shared=True
[platform_tool_requires]
cmake/*: cmake/3.28.1
[conf]
tools.files.download:verify=False
tools.system.package_manager:mode=install
Profile build:
[settings]
arch=armv8
build_type=Release
compiler=gcc
compiler.cppstd=gnu17
compiler.libcxx=libstdc++11
compiler.version=11
os=Linux
[platform_tool_requires]
cmake/*: cmake/3.28.1
[conf]
tools.files.download:verify=False
tools.system.package_manager:mode=install
======== Computing dependency graph ========
Graph root
cli
Requirements
cpptrace/0.5.4#2c7f75faefb5c7a7941a8038a88eb3d7 - Cache
libdwarf/0.9.1#74f3c2940c7dca2ec082aa9a35496242 - Cache
libunwind/1.8.0#045502d366b4ce2bc52a492648e62d2b - Cache
xz_utils/5.4.5#51e5a6e6564f4ea3afd79def01f035ad - Cache
zlib/1.3.1#f52e03ae3d251dec704634230cd806a2 - Cache
zstd/1.5.5#e03fb7b37b87f0174e9db4a8407e3f4d - Cache
Resolved version ranges
zlib/[>=1.2.11 <2]: zlib/1.3.1
======== Computing necessary packages ========
Requirements
cpptrace/0.5.4#2c7f75faefb5c7a7941a8038a88eb3d7:3b611c2e977f189280281bc0a74f169f7e091b0a#532179b1e04bcb3a27af0cee97db0db4 - Cache
libdwarf/0.9.1#74f3c2940c7dca2ec082aa9a35496242:4ebf043fd3e985871e510465ff0c67e1c560f73f#70443a7d30409a246b5d695eb3b5f766 - Cache
libunwind/1.8.0#045502d366b4ce2bc52a492648e62d2b:b8bd2935d210ef4550788af9f6c3d297fb0568cc#44da7e919d1e8c41a2357174679814bd - Cache
xz_utils/5.4.5#51e5a6e6564f4ea3afd79def01f035ad:9ca935e275f8163bfe39bdba58089b51be96e3b9#57ca9fd6cff7d5ede9b505f1d9c2d41d - Cache
zlib/1.3.1#f52e03ae3d251dec704634230cd806a2:9ca935e275f8163bfe39bdba58089b51be96e3b9#993ba7a01eadde7b8d1e3ecba3aeac18 - Cache
zstd/1.5.5#e03fb7b37b87f0174e9db4a8407e3f4d:e9ecd2d14baf28fa594c5dff5a85fa53ed05db21#f24a44df80ac516dcda5d1316a252f42 - Cache
======== Installing packages ========
xz_utils/5.4.5: Already installed! (1 of 6)
zlib/1.3.1: Already installed! (2 of 6)
zstd/1.5.5: Already installed! (3 of 6)
libdwarf/0.9.1: Already installed! (4 of 6)
libunwind/1.8.0: Already installed! (5 of 6)
cpptrace/0.5.4: Already installed! (6 of 6)
WARN: deprecated: Usage of deprecated Conan 1.X features that will be removed in Conan 2.X:
WARN: deprecated: 'cpp_info.names' used in: xz_utils/5.4.5, zstd/1.5.5, zlib/1.3.1, cpptrace/0.5.4
WARN: deprecated: 'cpp_info.build_modules' used in: xz_utils/5.4.5
WARN: deprecated: 'env_info' used in: zstd/1.5.5
WARN: deprecated: 'cpp_info.filenames' used in: cpptrace/0.5.4
======== Launching test_package ========
======== Computing dependency graph ========
Graph root
cpptrace/0.5.4 (test package): /cpptrace/test_package/conanfile.py
Requirements
cpptrace/0.5.4#2c7f75faefb5c7a7941a8038a88eb3d7 - Cache
libdwarf/0.9.1#74f3c2940c7dca2ec082aa9a35496242 - Cache
libunwind/1.8.0#045502d366b4ce2bc52a492648e62d2b - Cache
xz_utils/5.4.5#51e5a6e6564f4ea3afd79def01f035ad - Cache
zlib/1.3.1#f52e03ae3d251dec704634230cd806a2 - Cache
zstd/1.5.5#e03fb7b37b87f0174e9db4a8407e3f4d - Cache
======== Computing necessary packages ========
Requirements
cpptrace/0.5.4#2c7f75faefb5c7a7941a8038a88eb3d7:3b611c2e977f189280281bc0a74f169f7e091b0a#532179b1e04bcb3a27af0cee97db0db4 - Cache
libdwarf/0.9.1#74f3c2940c7dca2ec082aa9a35496242:4ebf043fd3e985871e510465ff0c67e1c560f73f#70443a7d30409a246b5d695eb3b5f766 - Cache
libunwind/1.8.0#045502d366b4ce2bc52a492648e62d2b:b8bd2935d210ef4550788af9f6c3d297fb0568cc#44da7e919d1e8c41a2357174679814bd - Cache
xz_utils/5.4.5#51e5a6e6564f4ea3afd79def01f035ad:9ca935e275f8163bfe39bdba58089b51be96e3b9#57ca9fd6cff7d5ede9b505f1d9c2d41d - Cache
zlib/1.3.1#f52e03ae3d251dec704634230cd806a2:9ca935e275f8163bfe39bdba58089b51be96e3b9#993ba7a01eadde7b8d1e3ecba3aeac18 - Cache
zstd/1.5.5#e03fb7b37b87f0174e9db4a8407e3f4d:e9ecd2d14baf28fa594c5dff5a85fa53ed05db21#f24a44df80ac516dcda5d1316a252f42 - Cache
======== Installing packages ========
xz_utils/5.4.5: Already installed! (1 of 6)
zlib/1.3.1: Already installed! (2 of 6)
zstd/1.5.5: Already installed! (3 of 6)
libdwarf/0.9.1: Already installed! (4 of 6)
libunwind/1.8.0: Already installed! (5 of 6)
cpptrace/0.5.4: Already installed! (6 of 6)
WARN: deprecated: Usage of deprecated Conan 1.X features that will be removed in Conan 2.X:
WARN: deprecated: 'cpp_info.names' used in: xz_utils/5.4.5, zstd/1.5.5, zlib/1.3.1, cpptrace/0.5.4
WARN: deprecated: 'cpp_info.build_modules' used in: xz_utils/5.4.5
WARN: deprecated: 'env_info' used in: zstd/1.5.5
WARN: deprecated: 'cpp_info.filenames' used in: cpptrace/0.5.4
======== Testing the package ========
Removing previously existing 'test_package' build folder: /cpptrace/test_package/build/gcc-11-armv8-gnu17-release
cpptrace/0.5.4 (test package): Test package build: build/gcc-11-armv8-gnu17-release
cpptrace/0.5.4 (test package): Test package build folder: /cpptrace/test_package/build/gcc-11-armv8-gnu17-release
cpptrace/0.5.4 (test package): Writing generators to /cpptrace/test_package/build/gcc-11-armv8-gnu17-release/generators
cpptrace/0.5.4 (test package): Generator 'CMakeDeps' calling 'generate()'
cpptrace/0.5.4 (test package): CMakeDeps necessary find_package() and targets for your CMakeLists.txt
find_package(cpptrace)
target_link_libraries(... cpptrace::cpptrace)
cpptrace/0.5.4 (test package): Generator 'CMakeToolchain' calling 'generate()'
cpptrace/0.5.4 (test package): CMakeToolchain generated: conan_toolchain.cmake
cpptrace/0.5.4 (test package): CMakeToolchain generated: CMakePresets.json
cpptrace/0.5.4 (test package): CMakeToolchain generated: ../../../CMakeUserPresets.json
cpptrace/0.5.4 (test package): Generator 'VirtualRunEnv' calling 'generate()'
cpptrace/0.5.4 (test package): Generating aggregated env files
cpptrace/0.5.4 (test package): Generated aggregated env files: ['conanrun.sh', 'conanbuild.sh']
======== Testing the package: Building ========
cpptrace/0.5.4 (test package): Calling build()
cpptrace/0.5.4 (test package): Running CMake.configure()
cpptrace/0.5.4 (test package): RUN: cmake -G "Unix Makefiles" -DCMAKE_TOOLCHAIN_FILE="/cpptrace/test_package/build/gcc-11-armv8-gnu17-release/generators/conan_toolchain.cmake" -DCMAKE_INSTALL_PREFIX="/cpptrace/test_package" -DCMAKE_POLICY_DEFAULT_CMP0091="NEW" -DCMAKE_BUILD_TYPE="Release" "/cpptrace/test_package"
-- Using Conan toolchain: /cpptrace/test_package/build/gcc-11-armv8-gnu17-release/generators/conan_toolchain.cmake
-- Conan toolchain: C++ Standard 17 with extensions ON
-- The CXX compiler identification is GNU 11.4.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Conan: Target declared 'cpptrace::cpptrace'
-- Conan: Target declared 'libdwarf::libdwarf'
-- Conan: Component target declared 'zstd::libzstd_shared'
-- Conan: Target declared 'ZLIB::ZLIB'
-- Conan: Component target declared 'libunwind::unwind'
-- Conan: Component target declared 'libunwind::generic'
-- Conan: Component target declared 'libunwind::ptrace'
-- Conan: Component target declared 'libunwind::setjmp'
-- Conan: Component target declared 'libunwind::coredump'
-- Conan: Target declared 'libunwind::libunwind'
-- Conan: Target declared 'LibLZMA::LibLZMA'
-- Conan: Including build module from '/root/.conan2/p/b/xz_ut8f51a21b6eda3/p/lib/cmake/conan-official-xz_utils-variables.cmake'
-- Configuring done
-- Generating done
-- Build files have been written to: /cpptrace/test_package/build/gcc-11-armv8-gnu17-release
cpptrace/0.5.4 (test package): Running CMake.build()
cpptrace/0.5.4 (test package): RUN: cmake --build "/cpptrace/test_package/build/gcc-11-armv8-gnu17-release" -- -j12
[ 50%] Building CXX object CMakeFiles/test_package.dir/test_package.cpp.o
[100%] Linking CXX executable test_package
/usr/bin/ld: /root/.conan2/p/b/cpptrc6811159a7cb9/p/lib/libcpptrace.so: undefined reference to `_ULaarch64_init_local'
/usr/bin/ld: /root/.conan2/p/b/cpptrc6811159a7cb9/p/lib/libcpptrace.so: undefined reference to `_ULaarch64_get_reg'
/usr/bin/ld: /root/.conan2/p/b/cpptrc6811159a7cb9/p/lib/libcpptrace.so: undefined reference to `_ULaarch64_step'
collect2: error: ld returned 1 exit status
gmake[2]: *** [CMakeFiles/test_package.dir/build.make:98: test_package] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:83: CMakeFiles/test_package.dir/all] Error 2
gmake: *** [Makefile:91: all] Error 2
ERROR: cpptrace/0.5.4 (test package): Error in build() method, line 21
cmake.build()
ConanException: Error 2 while executing
Note that this compiles fine without setting the shared option (i.e static flavour)
This comment has been minimized.
This comment has been minimized.
|
Hi @RubenRBS, thanks for noticing that. I tried running |
|
Fixed! We were missing a transitive declaration for libunwind's symbols My successful compilation logs:
```
conan create . --version=0.5.4 -b=missing -o="unwind=libunwind" -o="*:shared=True"
======== Exporting recipe to the cache ======== ======== Input profiles ======== Profile build: ======== Computing dependency graph ======== ======== Computing necessary packages ======== ======== Installing packages ======== -------- Installing package cpptrace/0.5.4 (6 of 6) -------- cpptrace/0.5.4: Running CMake.build() cpptrace/0.5.4: Package '3b611c2e977f189280281bc0a74f169f7e091b0a' built cpptrace/0.5.4: package(): Packaged 1 '.h' file: ctrace.h ======== Launching test_package ======== ======== Computing dependency graph ======== ======== Computing necessary packages ======== ======== Installing packages ======== ======== Testing the package ======== ======== Testing the package: Building ======== cpptrace/0.5.4 (test package): Running CMake.build() ======== Testing the package: Executing test ======== |
|
Oh awesome thank you so much! |
Conan v1 pipeline ✔️All green in build 8 (
Conan v2 pipeline ✔️
All green in build 8 (
|
Specify library name and version: cpptrace/all
I'm the author. This PR aims to
remove warnings about deprecated Conan 1.X features andsupport a notable configuration for cpptrace, closes jeremy-rifkin/cpptrace#110.