Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openmvg: add v2.1, avoid patching, improve OpenMP support #23836

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Apr 30, 2024

https://github.com/openMVG/openMVG/releases/tag/v2.1

A decent portion of the patching was avoidable by simply providing the necessary CMake vars via conan_deps.cmake loaded as a CMake project include.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@valgur valgur mentioned this pull request Jul 3, 2024
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Failure in build 3 (32e376682f9e40f6773c0191118dc32a93c3a70d):

  • openmvg/2.1:
    Didn't run or was cancelled before finishing

  • openmvg/2.0:
    Error running command conan info openmvg/2.0@#54ee5c5543a1ba49471530ff5de53897 --json {jsonName} -pr {profileName}:

    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=5
    os=Linux
    [options]
    openmvg:shared=False
    
    ...
    ERROR: Failed requirement 'coin-clp/1.17.9' from 'openmvg/2.0'
    ERROR: Unable to find 'coin-clp/1.17.9' in remotes
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.


Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

Failure in build 3 (32e376682f9e40f6773c0191118dc32a93c3a70d):

  • openmvg/2.1:
    Error running command conan graph info --requires openmvg/2.1@#4165c4eae43a716fc657ee0654fba7b4 --build openmvg/2.1@#4165c4eae43a716fc657ee0654fba7b4 -f json -pr:h /home/conan/workspace/prod-v2/bsr/60020/fadab/profile_linux_11_libstdcpp11_17_gcc_release_64.-shared-False.txt -pr:b /home/conan/workspace/prod-v2/bsr/60020/fadab/profile_linux_11_libstdcpp11_17_gcc_release_64..txt:

    ======== Computing dependency graph ========
    cereal/1.3.2: Not found in local cache, looking in remotes...
    cereal/1.3.2: Checking remote: conan-center
    cereal/1.3.2: Downloaded recipe revision b94802e904e1129e7fdb46d9bff5321d
    ceres-solver/2.2.0: Not found in local cache, looking in remotes...
    ceres-solver/2.2.0: Checking remote: conan-center
    ceres-solver/2.2.0: Downloaded recipe revision ffe493f7be8e4e680694d8c2fd1ea9c8
    eigen/3.4.0: Not found in local cache, looking in remotes...
    eigen/3.4.0: Checking remote: conan-center
    eigen/3.4.0: Downloaded recipe revision 2e192482a8acff96fe34766adca2b24c
    cmake/3.30.0: Not found in local cache, looking in remotes...
    cmake/3.30.0: Checking remote: conan-center
    cmake/3.30.0: Downloaded recipe revision b93985853f6298c398c76dd4c2ac02a2
    coin-clp/1.17.9: Not found in local cache, looking in remotes...
    coin-clp/1.17.9: Checking remote: conan-center
    coin-clp/1.17.9: Checking remote: c3i_PR-v2-23836
    Graph root
        cli
    Requirements
        cereal/1.3.2#b94802e904e1129e7fdb46d9bff5321d - Downloaded (conan-center)
        ceres-solver/2.2.0#ffe493f7be8e4e680694d8c2fd1ea9c8 - Downloaded (conan-center)
        eigen/3.4.0#2e192482a8acff96fe34766adca2b24c - Downloaded (conan-center)
        openmvg/2.1#4165c4eae43a716fc657ee0654fba7b4 - Cache
    Build requirements
        cmake/3.30.0#b93985853f6298c398c76dd4c2ac02a2 - Downloaded (conan-center)
    Resolved version ranges
        cmake/[>=3.16 <4]: cmake/3.30.0
    ERROR: Package 'coin-clp/1.17.9' not resolved: Unable to find 'coin-clp/1.17.9' in remotes.
    
  • openmvg/2.0:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants