Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restinio: bump 3ps to boost/1.85.0, asio/1.30.2, expected-lite/0.8.0 & fmt/11.0.1 #23864

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

gegles
Copy link
Contributor

@gegles gegles commented May 3, 2024

Specify library name and version: restinio/0.7.2


@conan-center-bot

This comment has been minimized.

1 similar comment
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

2 similar comments
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@gegles gegles changed the title restinio: bump 3p to boost/1.85.0 restinio: bump 3ps to boost/1.85.0, asio/1.30.2 & expected-lite/0.8.0 Jun 11, 2024
@conan-center-bot

This comment has been minimized.

@gegles
Copy link
Contributor Author

gegles commented Jun 11, 2024

@memsharded @uilianries @RubenRBS any chance this could be picked up? It's been about 5,6 weeks... Thx!

Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem with these version bumps might create more version conflicts that they solve. This is the reason why version bumps are not being merged as quickly as before, they are being prepared and orchestrated (mostly by @RubenRBS), so they are done simultaneously in order to reduce conflicts to users.

@@ -37,12 +37,12 @@ def layout(self):
def requirements(self):
self.requires("llhttp/9.1.3")
self.requires("fmt/10.2.1")
self.requires("expected-lite/0.6.3")
self.requires("expected-lite/0.8.0")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will create a conflict with jinja2cpp, still using previous version. Bump deps should be better orchestrated with others or wait until/if they can be moved to version-ranges

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still conflicting with jinja2cpp


if self.options.asio == "standalone":
self.requires("asio/1.29.0")
self.requires("asio/1.30.2")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will create conflicts with around 14 other libraries depending on previous versions of asio

else:
self.requires("boost/1.84.0")
self.requires("boost/1.85.0")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are like other 110 recipes depending on boost, practically none to 1.85, so this will conflict with all of them.

@memsharded memsharded self-assigned this Jun 11, 2024
@gegles
Copy link
Contributor Author

gegles commented Jun 11, 2024

The problem with these version bumps might create more version conflicts that they solve. This is the reason why version bumps are not being merged as quickly as before, they are being prepared and orchestrated (mostly by @RubenRBS), so they are done simultaneously in order to reduce conflicts to users.

Thanks for the clarification @memsharded. I get it, maybe previously the per-recipe deps bump would happen too aggressively, but the opposite, i.e. the status quo is not great either, and I am afraid things will get very stale over time...

I hope a clear process will emerge so that deps can be upgraded frequently and globally...

Would a cross-recipe PR upgrading a single dep at a time throughout the recipes be a better way? Or would it be too costly from a CI builds POV?

@memsharded
Copy link
Member

I hope a clear process will emerge so that deps can be upgraded frequently and globally...

Yes, the process is now already started, and moving to version ranges will be more and more spread. It just takes time to do it with the current infrastructure/CI without breaking too much users.

Would a cross-recipe PR upgrading a single dep at a time throughout the recipes be a better way? Or would it be too costly from a CI builds POV?

This is exactly what we are trying to do with the current work for a new CI pipeline. This new pipeline will support much better this kind of actions.

At this moment it is not possible and @RubenRBS has been orchestrating these changes with multiple parallel PRs, but we are getting closer to the new pipeline, so it might be better to wait until it is running.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@gegles gegles changed the title restinio: bump 3ps to boost/1.85.0, asio/1.30.2 & expected-lite/0.8.0 restinio: bump 3ps to boost/1.85.0, asio/1.30.2, expected-lite/0.8.0 & fmt/11.0.1 Jul 10, 2024
@conan-center-bot

This comment has been minimized.

@conan-center-bot conan-center-bot added Bump dependencies Only bumping dependencies versions in the recipe and removed Waiting for CI labels Jul 10, 2024
@conan-center-bot

This comment has been minimized.

@AbrilRBS AbrilRBS requested a review from memsharded July 10, 2024 22:22
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am afraid the commented conflicts are still there, this bumping of versions will create more issues than problems it might solve.

@@ -38,7 +38,7 @@ def layout(self):

def requirements(self):
self.requires("http_parser/2.9.4")
self.requires("fmt/10.1.1")
self.requires("fmt/11.0.1")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
self.requires("fmt/11.0.1")
self.requires("fmt/10.2.1")

This is the most popular version by far in ConanCenter, I'd use this one to avoid conflicts

@@ -37,12 +37,12 @@ def layout(self):
def requirements(self):
self.requires("llhttp/9.1.3")
self.requires("fmt/10.2.1")
self.requires("expected-lite/0.6.3")
self.requires("expected-lite/0.8.0")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still conflicting with jinja2cpp

@conan-center-bot conan-center-bot added Waiting for CI and removed Bump dependencies Only bumping dependencies versions in the recipe labels Sep 23, 2024
@conan-center-bot
Copy link
Collaborator

🚦 Thank for your Bump dependencies PR. The build service will be triggered soon by a Conan team member.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants