restinio: bump 3ps to boost/1.85.0, asio/1.30.2, expected-lite/0.8.0 & fmt/11.0.1
#23864
Conversation
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
gegles
changed the title
boost/1.85.0boost/1.85.0, asio/1.30.2 & expected-lite/0.8.0
This comment has been minimized.
This comment has been minimized.
|
@memsharded @uilianries @RubenRBS any chance this could be picked up? It's been about 5,6 weeks... Thx! |
There was a problem hiding this comment.
The problem with these version bumps might create more version conflicts that they solve. This is the reason why version bumps are not being merged as quickly as before, they are being prepared and orchestrated (mostly by @RubenRBS), so they are done simultaneously in order to reduce conflicts to users.
| @@ -37,12 +37,12 @@ def layout(self): | |||
| def requirements(self): | |||
| self.requires("llhttp/9.1.3") | |||
| self.requires("fmt/10.2.1") | |||
| self.requires("expected-lite/0.6.3") | |||
| self.requires("expected-lite/0.8.0") | |||
There was a problem hiding this comment.
This will create a conflict with jinja2cpp, still using previous version. Bump deps should be better orchestrated with others or wait until/if they can be moved to version-ranges
There was a problem hiding this comment.
This is still conflicting with jinja2cpp
recipes/restinio/v0.7/conanfile.py
Outdated
|
|
||
| if self.options.asio == "standalone": | ||
| self.requires("asio/1.29.0") | ||
| self.requires("asio/1.30.2") |
There was a problem hiding this comment.
This will create conflicts with around 14 other libraries depending on previous versions of asio
recipes/restinio/v0.7/conanfile.py
Outdated
| else: | ||
| self.requires("boost/1.84.0") | ||
| self.requires("boost/1.85.0") |
There was a problem hiding this comment.
There are like other 110 recipes depending on boost, practically none to 1.85, so this will conflict with all of them.
Thanks for the clarification @memsharded. I get it, maybe previously the per-recipe deps bump would happen too aggressively, but the opposite, i.e. the status quo is not great either, and I am afraid things will get very stale over time... I hope a clear process will emerge so that deps can be upgraded frequently and globally... Would a cross-recipe PR upgrading a single dep at a time throughout the recipes be a better way? Or would it be too costly from a CI builds POV? |
Yes, the process is now already started, and moving to version ranges will be more and more spread. It just takes time to do it with the current infrastructure/CI without breaking too much users.
This is exactly what we are trying to do with the current work for a new CI pipeline. This new pipeline will support much better this kind of actions. At this moment it is not possible and @RubenRBS has been orchestrating these changes with multiple parallel PRs, but we are getting closer to the new pipeline, so it might be better to wait until it is running. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
gegles
changed the title
boost/1.85.0, asio/1.30.2 & expected-lite/0.8.0boost/1.85.0, asio/1.30.2, expected-lite/0.8.0 & fmt/11.0.1
This comment has been minimized.
This comment has been minimized.
conan-center-bot
added
Bump dependencies
This comment has been minimized.
This comment has been minimized.
recipes/restinio/all/conanfile.py
Outdated
| @@ -38,7 +38,7 @@ def layout(self): | |||
|
|
|||
| def requirements(self): | |||
| self.requires("http_parser/2.9.4") | |||
| self.requires("fmt/10.1.1") | |||
| self.requires("fmt/11.0.1") | |||
There was a problem hiding this comment.
| self.requires("fmt/11.0.1") | |
| self.requires("fmt/10.2.1") |
This is the most popular version by far in ConanCenter, I'd use this one to avoid conflicts
| @@ -37,12 +37,12 @@ def layout(self): | |||
| def requirements(self): | |||
| self.requires("llhttp/9.1.3") | |||
| self.requires("fmt/10.2.1") | |||
| self.requires("expected-lite/0.6.3") | |||
| self.requires("expected-lite/0.8.0") | |||
There was a problem hiding this comment.
This is still conflicting with jinja2cpp
conan-center-bot
added
Waiting for CI
and removed
Bump dependencies
This comment has been minimized.
This comment has been minimized.
|
Warning Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement. 🚦 Thank for your Bump dependencies PR. The build service will be triggered soon by a Conan team member. |
Specify library name and version: restinio/0.7.2