Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nghttp3: add version 1.3.0 #23935

Merged
merged 2 commits into from
May 13, 2024
Merged

Conversation

toge
Copy link
Contributor

@toge toge commented May 9, 2024

Specify library name and version: nghttp3/1.3.0

ngtcp2/nghttp3@v1.2.0...v1.3.0


@conan-center-bot

This comment has been minimized.

@AbrilRBS
Copy link
Member

AbrilRBS commented May 9, 2024

As shown https://c3i.jfrog.io/c3i/misc-v2/logs/pr/23935/1-linux-gcc/nghttp3/1.3.0//13be611585c95453f1cbbd053cea04b3e64470ca-build.txt static builds are building the tests now, which we should probably be skipping

Also seems like STATIC_LIB_SUFFIX changed, should the recipe reflect this?

@toge
Copy link
Contributor Author

toge commented May 10, 2024

@RubenRBS
Thank you for your comment.

The STATIC_LIB_SUFFIX is not set in our environment.
It is only set when building both shared and static.

https://github.com/ngtcp2/nghttp3/blob/v1.3.0/CMakeLists.txt#L180-L182

if(ENABLE_SHARED_LIB AND ENABLE_STATIC_LIB AND MSVC AND NOT STATIC_LIB_SUFFIX)
  set(STATIC_LIB_SUFFIX "_static")
endif()

@conan-center-bot conan-center-bot removed the Bump version PR bumping version without recipe modifications label May 10, 2024
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 2 (ba459aeeed0d2c584e9230587f8132f01ef720c1):

  • nghttp3/1.3.0:
    All packages built successfully! (All logs)

  • nghttp3/1.0.0:
    All packages built successfully! (All logs)

  • nghttp3/1.1.0:
    All packages built successfully! (All logs)

  • nghttp3/0.15.0:
    All packages built successfully! (All logs)

  • nghttp3/1.2.0:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 2 (ba459aeeed0d2c584e9230587f8132f01ef720c1):

  • nghttp3/1.1.0:
    All packages built successfully! (All logs)

  • nghttp3/1.0.0:
    All packages built successfully! (All logs)

  • nghttp3/1.3.0:
    All packages built successfully! (All logs)

  • nghttp3/0.15.0:
    All packages built successfully! (All logs)

  • nghttp3/1.2.0:
    All packages built successfully! (All logs)

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the extra comments too! :)

@conan-center-bot conan-center-bot merged commit ef13bdd into conan-io:master May 13, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants