Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libgit2: add version 1.8.1 #23953

Merged
merged 2 commits into from
May 20, 2024
Merged

libgit2: add version 1.8.1 #23953

merged 2 commits into from
May 20, 2024

Conversation

toge
Copy link
Contributor

@toge toge commented May 10, 2024 •
edited
Loading

Specify library name and version: libgit2/1.8.1

libgit2/libgit2@v1.7.2...v1.8.1

  • Since 1.8.0, libgit2 add the values of USE_SSH as exec and libssh2. In conan CCI, libssh2 seems to be adequate.
  • Since 1.8.1, libgit2 add USE_HTTP_PARSER to select http parser library. (http-parser and llhttp)

@ghost ghost mentioned this pull request May 10, 2024
Closed
AbrilRBS
AbrilRBS previously approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

recipes/libgit2/all/conanfile.py Outdated
@@ -151,6 +151,8 @@ def generate(self):
tc.variables["REGEX_BACKEND"] = self.options.with_regex
if is_msvc(self):
tc.variables["STATIC_CRT"] = is_msvc_static_runtime(self)
if Version(self.version) >= "1.8.0":
tc.variables["USE_SSH"] = "libssh2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This keeps the same old behaviour as per libgit2/libgit2@v1.7.2...v1.8.0#diff-95a55896bed1a5af65001605d4d237f52bed5366bd33d43528638dc756e26efbR7, thanks!

@AbrilRBS AbrilRBS self-assigned this May 10, 2024
@ericLemanissier ericLemanissier mentioned this pull request May 10, 2024
Closed
@conan-center-bot

This comment has been minimized.

Sign in to view
This was referenced May 11, 2024
Open
Closed
@toge toge changed the title libgit2: add version 1.8.0 libgit2: add version 1.8.1 May 19, 2024
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 2 (3d00ee607fb12914348897b0adecfdbda6f28516):

  • libgit2/1.7.2:
    All packages built successfully! (All logs)

  • libgit2/1.8.1:
    All packages built successfully! (All logs)

  • libgit2/1.4.3:
    All packages built successfully! (All logs)

  • libgit2/1.5.0:
    All packages built successfully! (All logs)

  • libgit2/1.2.0:
    All packages built successfully! (All logs)

  • libgit2/1.3.0:
    All packages built successfully! (All logs)

  • libgit2/1.0.1:
    All packages built successfully! (All logs)

  • libgit2/1.1.1:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 2 (3d00ee607fb12914348897b0adecfdbda6f28516):

  • libgit2/1.2.0:
    All packages built successfully! (All logs)

  • libgit2/1.8.1:
    All packages built successfully! (All logs)

  • libgit2/1.7.2:
    All packages built successfully! (All logs)

  • libgit2/1.0.1:
    All packages built successfully! (All logs)

  • libgit2/1.5.0:
    All packages built successfully! (All logs)

  • libgit2/1.1.1:
    All packages built successfully! (All logs)

  • libgit2/1.4.3:
    All packages built successfully! (All logs)

  • libgit2/1.3.0:
    All packages built successfully! (All logs)

uilianries
uilianries approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checked the versions diff and looks good. The upstream uses STREQUAL ON for USE_SSH, not best approach but works. Thank you!

@uilianries uilianries requested a review from AbrilRBS May 20, 2024 09:33
AbrilRBS
AbrilRBS approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks!

@conan-center-bot conan-center-bot merged commit 6952bdf into conan-io:master May 20, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbrilRBS AbrilRBS AbrilRBS approved these changes

@uilianries uilianries uilianries approved these changes

Assignees

@AbrilRBS AbrilRBS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@toge @conan-center-bot @uilianries @AbrilRBS